Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] Move initialization from helper script to Vue component #1128

Merged
merged 6 commits into from
Feb 5, 2025
Merged

[stable29] Move initialization from helper script to Vue component #1128

merged 6 commits into from
Feb 5, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 5, 2025 •
edited by danxuliu
Loading

Backport of #1107

@backportbot backportbot bot requested review from szaimen and danxuliu February 5, 2025 10:59
@backportbot backportbot bot added this to the Nextcloud 29.0.12 milestone Feb 5, 2025
@danxuliu
Extract initializing the PDFViewerApplicationOptions to its own method
055a97e 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
Move PDFViewerApplicationOptions from helper script to Vue component
50e8c47 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
Extract getting viewer template parameters to its own method
a6769ad 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
Extract initializing the PDFViewerApplication to its own method
15fb655 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
Move PDFViewerApplication setup from helper script to Vue component
8466f85 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu force-pushed the backport/1107/stable29 branch from 5280c12 to 8466f85 Compare February 5, 2025 12:06
@danxuliu
Copy link
Member

danxuliu commented Feb 5, 2025

/compile /

@nextcloud-command
chore(assets): Recompile assets
be70245 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@danxuliu danxuliu marked this pull request as ready for review February 5, 2025 12:32
danxuliu
danxuliu approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu danxuliu merged commit b946202 into stable29 Feb 5, 2025
36 checks passed
@danxuliu danxuliu deleted the backport/1107/stable29 branch February 5, 2025 12:34
@Altahrim Altahrim mentioned this pull request Feb 5, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@danxuliu danxuliu

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 29.0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@danxuliu @nextcloud-command