Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filename): Exclude part/transfer files from checks #330

Merged
merged 5 commits into from
Apr 3, 2023
Merged

fix(filename): Exclude part/transfer files from checks #330

merged 5 commits into from
Apr 3, 2023

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen
test(filename): Add a test for a negative filename match
7dab2a3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Mar 31, 2023
@nickvergessen
feat(logging): Add debug logging for why a path was blocked
74b70ab 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(filename): Exclude part/transfer files from checks
ee5d3a0 
Their name is not the final, the size is wrong, tags are missing, etc.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review March 31, 2023 14:10
@nickvergessen nickvergessen changed the title test(filename): Add a test for a negative filename match fix(filename): Exclude part/transfer files from checks Mar 31, 2023
@nickvergessen
debug(tests): Debug the trashbin test
01f8c14 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(CI): Clear the trash between tests
2528736 
Signed-off-by: Joas Schilling <coding@schilljs.com>
ShGKme
ShGKme approved these changes Mar 31, 2023
View reviewed changes
Copy link

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the issue.

@nickvergessen nickvergessen merged commit e1bcd68 into master Apr 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/fix-negative-file-name-match branch April 3, 2023 08:07
@nickvergessen
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud

This comment was marked as off-topic.

Sign in to view
@nickvergessen
Copy link
Member Author

/backport to stable25

@backportbot-nextcloud

This comment was marked as off-topic.

Sign in to view
@nickvergessen
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud

This comment was marked as off-topic.

Sign in to view
This was referenced May 10, 2023
Merged
Merged
Closed
This was referenced Aug 14, 2024
Open
Closed
@st3iny st3iny mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@ShGKme ShGKme ShGKme approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@nickvergessen nickvergessen

Labels
3. to review backport-request bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @juliusknorr @ShGKme