Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed example odt to docx, minor content changes #8

Merged
merged 1 commit into from
May 4, 2020

Conversation

wiswedel
Copy link
Contributor

implements #7

Signed-off-by: Sascha Wiswedel sascha.wiswedel@nextcloud.com

Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
@wiswedel wiswedel requested a review from rullzer March 10, 2020 21:33
@wiswedel wiswedel linked an issue Mar 10, 2020 that may be closed by this pull request
@wiswedel
Copy link
Contributor Author

before

before

after

after

@wiswedel wiswedel requested review from rullzer and skjnldsv and removed request for rullzer March 27, 2020 22:37
@skjnldsv
Copy link
Member

I find it kind of sad to go for non open-sourced file format :(

@jancborchardt
Copy link
Member

The changes to Example.md are of course great.

For the odt/docx I would say though that this should be fixed at OnlyOffice, and that we shouldn’t change to docx for this. We already get some criticism for partnering with a project which is perceived as not-so-open-source by some, so we shouldn’t make it worse by putting docx over odt in the default files.

Or what do you think @jospoortvliet @karlitschek?

@karlitschek
Copy link
Member

Nice. A new contributor :-)
I´m not religious about the file format. Both are widely used and are supported by Nextcloud. Of course docx has better compatibility as discussed. Not only ONLYOFFICE but also the applications that normal users have on their phones and desktops. So I think switching to docx is ok.

@wiswedel wiswedel merged commit 396b85a into master May 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the wiswedel/ooxml branch May 4, 2020 12:32
@wiswedel
Copy link
Contributor Author

wiswedel commented May 4, 2020

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use docx/xlsx/pptx for office files
5 participants