Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support sha-1 algo for user certificate signature #893

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Feb 5, 2025

Depending on the server's OpenSSL config, the hashing algorithm will be different. This is needed to support servers that haven't moved to a more secure hashing algorithm yet.

Most of the changes are made in order to be able to specify the hashing algorithm when loading the public key.
So we delay loading the public key until we know which algorithm to use.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Feb 5, 2025
@artonge artonge requested review from nfebe and skjnldsv February 5, 2025 18:03
@artonge artonge added bug Something isn't working javascript Javascript related ticket 3. to review Waiting for reviews labels Feb 5, 2025
@artonge artonge added this to the Nextcloud 31 milestone Feb 5, 2025
@artonge
Copy link
Collaborator Author

artonge commented Feb 5, 2025

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.15%. Comparing base (78b58b8) to head (245eb26).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   31.99%   32.15%   +0.15%     
==========================================
  Files          26       26              
  Lines        1322     1325       +3     
  Branches       52       50       -2     
==========================================
+ Hits          423      426       +3     
  Misses        897      897              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge merged commit 1b69c68 into master Feb 6, 2025
42 checks passed
@artonge artonge deleted the artonge/fix/user_certificate_validation_sha-1 branch February 6, 2025 11:13
Copy link

backportbot bot commented Feb 6, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/893/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8578ec18 c14a7a86 a044e662 245eb260

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/893/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants