-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support sha-1 algo for user certificate signature #893
Conversation
Signed-off-by: Louis Chemineau <louis@chmn.me>
/backport to stable30 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
==========================================
+ Coverage 31.99% 32.15% +0.15%
==========================================
Files 26 26
Lines 1322 1325 +3
Branches 52 50 -2
==========================================
+ Hits 423 426 +3
Misses 897 897
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/893/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8578ec18 c14a7a86 a044e662 245eb260
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/893/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Depending on the server's OpenSSL config, the hashing algorithm will be different. This is needed to support servers that haven't moved to a more secure hashing algorithm yet.
Most of the changes are made in order to be able to specify the hashing algorithm when loading the public key.
So we delay loading the public key until we know which algorithm to use.