Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce scope of intercepted requested #858

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 9, 2025

This prevents other DAV scopes to be intercepted.

@artonge artonge added 3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket labels Jan 9, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 9, 2025
@artonge artonge requested a review from skjnldsv January 9, 2025 12:09
@artonge artonge self-assigned this Jan 9, 2025
@artonge artonge marked this pull request as ready for review January 9, 2025 12:09
@artonge artonge changed the title fix: Scope of intercepted requested fix: Reduce scope of intercepted requested Jan 9, 2025
This prevent other dav scopes to be intercepted.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/dav_scope branch from 3a83e6a to 18c55b4 Compare January 9, 2025 16:40
@artonge
Copy link
Collaborator Author

artonge commented Jan 9, 2025

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge enabled auto-merge January 9, 2025 16:47
@artonge artonge merged commit af20670 into master Jan 9, 2025
40 checks passed
@artonge artonge deleted the artonge/fix/dav_scope branch January 9, 2025 16:47
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.09%. Comparing base (c11ecc3) to head (9024afa).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/services/webDavProxy.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   22.09%   22.09%           
=======================================
  Files          29       29           
  Lines        1249     1249           
  Branches       26       26           
=======================================
  Hits          276      276           
  Misses        971      971           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants