Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "64-bit is required for NC26" #9615

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Revert "64-bit is required for NC26" #9615

merged 2 commits into from
Feb 8, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 7, 2023

@come-nc come-nc self-assigned this Feb 7, 2023
@come-nc come-nc added this to the Nextcloud 26 milestone Feb 7, 2023
@come-nc come-nc requested a review from szaimen February 7, 2023 13:37
@come-nc come-nc mentioned this pull request Feb 7, 2023
Closed
20 tasks
@come-nc
Copy link
Contributor Author

come-nc commented Feb 7, 2023

/backport to stable25

@come-nc come-nc requested a review from szaimen February 8, 2023 09:20
@szaimen
Copy link
Contributor

szaimen commented Feb 8, 2023 •
edited
Loading

Maybe remove the (64-bit) fron the table?

come-nc and others added 2 commits February 8, 2023 10:32
@come-nc
Revert "64-bit is required for NC26"
8db7f48 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix back wording after revert
2015f28 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the revert-9274-enh/noid/64-bit-26 branch from 2037844 to 2015f28 Compare February 8, 2023 09:32
@come-nc
Copy link
Contributor Author

come-nc commented Feb 8, 2023

Maybe remove the (64-bit) fron the table?

You can open another PR for improvements but the point here is only to revert the 32bit drop information from documentation.

szaimen
szaimen approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@come-nc come-nc merged commit 98cb7ac into master Feb 8, 2023
@come-nc come-nc deleted the revert-9274-enh/noid/64-bit-26 branch February 8, 2023 12:31
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

@come-nc come-nc

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
2 participants
@come-nc @szaimen