Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KArchive to client Dockerfiles #386

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add KArchive to client Dockerfiles #386

merged 1 commit into from
Jul 28, 2022

Conversation

claucambra
Copy link
Contributor

This should fix failures with this PR on the desktop client side: nextcloud/desktop#4768

@claucambra claucambra self-assigned this Jul 21, 2022
@claucambra claucambra force-pushed the work/karchive branch 7 times, most recently from 5e35110 to 102fbd1 Compare July 21, 2022 15:40
mgallien
mgallien reviewed Jul 21, 2022
View reviewed changes
client/Dockerfile Outdated Show resolved Hide resolved
client/Dockerfile Outdated Show resolved Hide resolved
mgallien
mgallien reviewed Jul 21, 2022
View reviewed changes
client-appimage/Dockerfile Outdated Show resolved Hide resolved
client-appimage/Dockerfile Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the work/karchive branch 2 times, most recently from 05d5694 to 3742f7d Compare July 21, 2022 16:46
mgallien
mgallien requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build of ecm framework is failing (speaks about missing sphinx module for qt docs and I cannot remember if that one is really mandatory or we could just disable it)

@claucambra
Add KArchive to client Dockerfiles
29bf73d 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra
Copy link
Contributor Author

build of ecm framework is failing (speaks about missing sphinx module for qt docs and I cannot remember if that one is really mandatory or we could just disable it)

Fixed the build :)

@claucambra claucambra requested a review from mgallien July 22, 2022 14:12
@claucambra claucambra merged commit e8a60a6 into master Jul 28, 2022
@claucambra claucambra deleted the work/karchive branch July 28, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claucambra @mgallien