Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix migration from legacy clients. #7807

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Bugfix migration from legacy clients. #7807

merged 6 commits into from
Feb 11, 2025
+128 −117

Conversation

camilasan
Copy link
Member

No description provided.

@camilasan camilasan force-pushed the bugfix/migration branch 4 times, most recently from a7dea6b to 2657ba5 Compare January 29, 2025 15:31
@camilasan camilasan requested review from mgallien and nilsding and removed request for mgallien January 29, 2025 15:32
@camilasan camilasan marked this pull request as ready for review January 29, 2025 15:32
@camilasan camilasan added this to the 3.16.0 milestone Jan 29, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2025
View reviewed changes
src/gui/application.cpp Fixed Show resolved Hide resolved
@camilasan camilasan mentioned this pull request Feb 4, 2025
Closed
@camilasan camilasan force-pushed the bugfix/migration branch 5 times, most recently from 5904087 to 0dbe09a Compare February 11, 2025 08:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1.9% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
95 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

mgallien and others added 6 commits February 11, 2025 10:57
@mgallien
while migrating from another version, clean updater config
b3886ed 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@camilasan @mgallien
Look for previous used application name for config folder.
5236b1b 
oldDir => legacyDataDir.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
Update the max folder and the max account version.
69b7e05 
Improve log output when migrating settings.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
Check for FoldersWithPlaceholders when migrating account's folders.
59f1b6a 
Improve logs.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
Remove check for overrideurl when migrating account.
5104398 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
Overwrite the user exclude list when the client is branded.
417f692 
Enforce specific sync-exclude file to all users.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien merged commit 29858d0 into master Feb 11, 2025
10 of 14 checks passed
@mgallien mgallien deleted the bugfix/migration branch February 11, 2025 09:57
@github-actions GitHub Actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7807.zip

SHA256 checksum: df96520c5905afa876f024f3bc4a945aad466fe9c88921eb218da9bc07ae20d7

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsding nilsding nilsding approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nilsding @mgallien