Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/do not always free up storage windows shortcuts #7713

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Jan 3, 2025

Close #7696

@mgallien mgallien added this to the 3.15.3 milestone Jan 3, 2025
@mgallien
Copy link
Collaborator Author

mgallien commented Jan 3, 2025

/backport to stable-3.15

@mgallien
Copy link
Collaborator Author

mgallien commented Jan 3, 2025

custom build from the branch
https://cloud.nextcloud.com/s/QCPKYQDfqtFm4Po
use with caution, no QA

Close #7696

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to enable move to trash, we check availability of a folder recursively

that will trigger implicit hydration of its content

we will now prevent moving to trash for VFS CfApi native VFS on Windows

will fix teh bug and probably be much more robust and reliable

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/doNotAlwaysFreeUpStorageWindowsShortcuts branch from be0d7f4 to 6f8a40f Compare January 3, 2025 16:14
@mgallien mgallien merged commit a25dc6a into master Jan 3, 2025
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/doNotAlwaysFreeUpStorageWindowsShortcuts branch January 3, 2025 16:14
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7713-6f8a40f73e8f965da5a6e8771fdbfd96cf3f8537-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Jan 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Local copies of .lnk files are deleted upon re-sync when using virtual files
3 participants