Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small READMEs fix/updates #7284

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Small READMEs fix/updates #7284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d24f3e1
Fix the list of steps order.
camilasan Oct 8, 2024
4e2fb62
Fix permanent link to mac-crafter README.
camilasan Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ make

> [!TIP]
> For building the client for mac OS we have a tool called mac-crafter.
> You will find instructions on how to use it at [admin/osx/mac-crafter](https://github.com/nextcloud/desktop/blob/9ab514cfa845ed7bf530a1b9312d75c9a5935a46/admin/osx/mac-crafter/README.md).
> You will find instructions on how to use it at [admin/osx/mac-crafter](https://github.com/nextcloud/desktop/tree/32305e4c15ff95d00fae07e82e750fe9051b2250/admin/osx/mac-crafter).

5. 🐛 [Pick a good first issue](https://github.com/nextcloud/desktop/labels/good%20first%20issue)
6. 👩‍🔧 Create a branch and make your changes. Remember to sign off your commits using `git commit -sm "Your commit message"`
Expand Down
17 changes: 9 additions & 8 deletions admin/osx/mac-crafter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,36 +23,37 @@ cd admin/osx/mac-crafter
swift run mac-crafter
```

3.1 Sign the application bundle by adding the following parameter:
3. Sign the application bundle by adding the following parameter:
`-c <Development or developer codesigning certificate name>`
The whole command will look like this:
```
swift run mac-crafter -c "Apple Development: <certificate common name>"
```

The resulting app bundle will be placed under the `product` folder in the mac-crafter folder.
> [!NOTE]
> The resulting app bundle will be placed under the `product` folder in the mac-crafter folder.

> [!TIP]
> Check [Apple's oficial documentation about code signing](https://developer.apple.com/documentation/xcode/using-the-latest-code-signature-format).

3.2 Build the file provider module with this option:
### Extra options

- Build the file provider module with this option:
```
--build-file-provider-module
```

3.3 Disable the auto-updater:
- Disable the auto-updater:
```
--disable-autoupdater
```

3.4 Manually set the architecture you are building for:
- Manually set the architecture you are building for:

```
--arch arm64
--arch <arm64|x86_64>
```

The options are `x86_64` and `arm64`.

### How to build the app bundle for arm and intel

To achieve this we are using a Python script called `make_universal.py` which bundles together the arm64 and Intel builds into one universal app bundle. This script can be found under `admin/osx`. You can invoke it like so:
Expand Down
Loading