Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert always enable http2 #7182

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Revert always enable http2 #7182

merged 1 commit into from
Sep 23, 2024

Conversation

claucambra
Copy link
Collaborator

Should fix #7136 and #7171

@claucambra claucambra self-assigned this Sep 22, 2024
@claucambra claucambra force-pushed the bugfix/revert-always-use-http2 branch from 9b93050 to e8d9618 Compare September 22, 2024 08:55
@mgallien
Copy link
Collaborator

then we will get back issues when people have http1.1 broken and http2 working
we must investigate to figure out what is the problem and only merge this is there is a Qt bug

mgallien
mgallien requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change it such that we would have an environment variable to force disable http2 when needed and keep it enable by default ?

@camilasan camilasan mentioned this pull request Sep 23, 2024
Open
15 tasks
mgallien
mgallien approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things are broken after this change
we unfortunately have to revert

@claucambra @mgallien
Revert "Merge pull request #6986 from nextcloud/feature/alwaysEnableH…
389d653 
…ttp2"

This reverts commit 5baec6f, reversing
changes made to ab06ecb.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/revert-always-use-http2 branch from e8d9618 to 389d653 Compare September 23, 2024 11:19
@mgallien mgallien enabled auto-merge September 23, 2024 11:19
@mgallien
Copy link
Collaborator

/backport to stable-3.14

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7182-389d6536e593517bb6fddab9789f76cd741edf1b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgallien mgallien merged commit 0c3f0a0 into master Sep 23, 2024
13 of 15 checks passed
@mgallien mgallien deleted the bugfix/revert-always-use-http2 branch September 23, 2024 14:24
@backportbot backportbot bot mentioned this pull request Sep 23, 2024
Merged
@melroy89 melroy89 mentioned this pull request Sep 23, 2024
Closed
8 tasks
@nursoda
Copy link

nursoda commented Sep 23, 2024 •
edited
Loading

AppImage file: nextcloud-PR-7182-389d6536e593517bb6fddab9789f76cd741edf1b-x86_64.AppImage

WFM after start (NC 28.0.10 on NGINX 1.27.1/PHP-FPM 8.3.11/MariaDB 11.5.2). However, after standby/resume two of my clouds (externally hosted ones) do not reconnect for 1-2 minutes (connection failure) while the browser can connect. No way to immediately recover from that. Self-healed after 2 minutes. Without interaction, right after that, another (inhouse hosted NC) yielded connection timeout for 1-2 minutes before re-syncing and recovering. I never saw that behavior with 1.13.4.

@nursoda nursoda mentioned this pull request Sep 23, 2024
Closed
8 tasks
@cetcondor cetcondor mentioned this pull request Sep 25, 2024
Closed
8 tasks
@mgallien mgallien mentioned this pull request Sep 25, 2024
Closed
8 tasks
@hhartz
Copy link

hhartz commented Dec 19, 2024

@claucambra FYI, https://bugreports.qt.io/browse/QTBUG-132277

@hhartz
Copy link

hhartz commented Dec 19, 2024

pinging @mgallien as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync error: “Server stopped accepting new streams before this stream was established”
5 participants
@claucambra @mgallien @nextcloud-desktop-bot @nursoda @hhartz