Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a permanent log of delete actions #7028

Merged
merged 2 commits into from
Oct 1, 2024
Merged

create a permanent log of delete actions #7028

merged 2 commits into from
Oct 1, 2024

Conversation

mgallien
Copy link
Collaborator

will log all deletions with the result of the discovery by the sync enginre

should enable analyze even long time after such a delete occured

@mgallien mgallien force-pushed the feature/permanentDeleteLog branch from c162e2e to 831de27 Compare August 26, 2024 14:41
@mgallien mgallien changed the base branch from stable-3.13 to master August 26, 2024 17:28
@mgallien mgallien force-pushed the feature/permanentDeleteLog branch from 831de27 to aced891 Compare August 26, 2024 17:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
42.2% Coverage on New Code (required ≥ 80%)
16.7% Duplication on New Code (required ≤ 3%)
52 New Code Smells (required ≤ 0)
D Security Rating on New Code (required ≥ A)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien
create a permanent log of delete actions
e2f94d8 
will log all deletions with the result of the discovery by the sync
enginre

should enable analyze even long time after such a delete occured

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
remove not so usefull log line for new files
ab2bf98 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/permanentDeleteLog branch from aced891 to ab2bf98 Compare October 1, 2024 13:43
@mgallien mgallien merged commit c771c41 into master Oct 1, 2024
10 of 14 checks passed
@mgallien mgallien deleted the feature/permanentDeleteLog branch October 1, 2024 14:39
@mgallien
Copy link
Collaborator Author

mgallien commented Oct 1, 2024

/backport to stable-3.12

@backportbot backportbot bot mentioned this pull request Oct 1, 2024
Merged
2 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.2% Coverage on New Code (required ≥ 80%)
59 New Code Smells (required ≤ 0)
D Security Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7028-ab2bf984e7df346a1e9ffbb020d83bf68cb4e7c7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @claucambra