Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove most usages of transparent background: fix visual regressions #6993

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

mgallien
Copy link
Collaborator

with transparent backgrounds, most of teh time the result is hard to read

that is mostly unintended and unless there is some blur added, the UI becomes unusable

Close #6992

@mgallien mgallien force-pushed the bugfix/removeTransparentBackgroundColor branch from fbc0fca to 60942e2 Compare August 12, 2024 12:57
@mgallien mgallien enabled auto-merge August 12, 2024 13:41
with transparent backgrounds, most of teh time the result is hard to
read

that is mostly unintended and unless there is some blur added, the UI
becomes unusable

Close #6992

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
avoid having many background colors being transparent when they should
never have been

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the bckground of buttons on teh top bar of main dialog had a wrong color
not matching the top bar background color

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/removeTransparentBackgroundColor branch from d894040 to c39e94e Compare August 12, 2024 14:53
@mgallien mgallien disabled auto-merge August 12, 2024 14:53
@mgallien mgallien merged commit 74fa0a6 into master Aug 12, 2024
11 of 14 checks passed
@mgallien mgallien deleted the bugfix/removeTransparentBackgroundColor branch August 12, 2024 14:53
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6993-c39e94ef6f2b8d68aa308b675eca4f0be259305b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: some windows or dialogs have transparent background: hard to use and hard to read
3 participants