Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion caused by default value call in desktopEnterpriseChannel #6963

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

claucambra
Copy link
Collaborator

defaultUpdateChannel calls desktopEnterpriseChannel, so if the enterprise channel is not set in the config file, getting the default value via defaultUpdateChannel causes an infinite loop

@claucambra claucambra self-assigned this Aug 2, 2024
…iseChannel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@camilasan camilasan force-pushed the bugfix/enterprise-channel-infinite-recursion branch from 63b1dcd to c475eda Compare August 4, 2024 18:37
@camilasan camilasan merged commit 6dbf41e into master Aug 4, 2024
11 of 14 checks passed
@camilasan camilasan deleted the bugfix/enterprise-channel-infinite-recursion branch August 4, 2024 18:37
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6963-c475edafd1b7abd656fc27450e4d55e7194916f2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Aug 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants