Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/rw folders broken #6839

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Bugfix/rw folders broken #6839

merged 3 commits into from
Jun 28, 2024

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 26, 2024 •
edited
Loading

Closes #6741
Closes #6824
Closes #6796

@claucambra claucambra requested review from mgallien and camilasan June 26, 2024 10:05
@claucambra claucambra self-assigned this Jun 26, 2024
@claucambra claucambra added this to the 3.13.1 milestone Jun 26, 2024
@A-Aurel A-Aurel mentioned this pull request Jun 27, 2024
Closed
8 tasks
mgallien
mgallien approved these changes Jun 28, 2024
View reviewed changes
src/libsync/filesystem.cpp Show resolved Hide resolved
@claucambra
Ensure we are re-adding same permissions as removed
c34edbe 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Do not re-generate standard string path twice
26eab22 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Do not wrap macOS ifdefs in filesystem when parent function already w…
051a225 
…rapped in ifdef

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/rw-folders-broken branch from 32ad968 to 051a225 Compare June 28, 2024 07:55
@mgallien mgallien enabled auto-merge June 28, 2024 08:00
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6839-051a225d83eceef73cc4f744b065b62d60f49e07-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
7 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit f44eb5b into master Jun 28, 2024
12 of 14 checks passed
@mgallien mgallien deleted the bugfix/rw-folders-broken branch June 28, 2024 08:39
@claucambra
Copy link
Collaborator Author

/backport to stable-3.13

@backportbot backportbot bot mentioned this pull request Jun 28, 2024
Merged
@PhilippSchlesinger
Copy link

PhilippSchlesinger commented Jul 3, 2024 •
edited
Loading

@claucambra there are recent folder permissions bugs #6863 and #6875 regarding the changes in this PR.

@loulous24 loulous24 mentioned this pull request Jul 5, 2024
Open
8 tasks
@suiso67 suiso67 mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.13.1
4 participants
@claucambra @nextcloud-desktop-bot @PhilippSchlesinger @mgallien