Allow deletion of virtual suffix placeholder files #6821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would make sense to test add a test for this? |
I amended the existing test |
|
Looking at the test I need to make a couple more small changes |
|
Now fixed |
mgallien
approved these changes
Jun 28, 2024
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…behaviour Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
… delete command to server Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…testsyncvirtualfiles Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
8437b2e to
2915e25
Compare
|
/backport to stable-3.13 |
|
AppImage file: nextcloud-PR-6821-2915e2517e26e2793c445d93341d37cedd5a9e6a-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing their deletion is a more confusing and counterintuitive behaviour