Bugfix. E2EE. Always migrate from 1.2 to 2.0, even with nested folders.

[allexzander]

No description provided.

[allexzander]

We have an issue with old E2EE folders (version < 2.0) if there are nested folders inside those and the user makes a change in the nested folder. The encrypted folder then becomes broken as the nested folder + root E2EE folder relation is getting messed up. We already have a code for proper migration. We did not enable it for folders with nested folders for some reason of mobile client limitations. But this is the proper way to do it on a desktop and prevents issues with using such old folders later.

This is probably the problem some users are still suffering in nextcloud/ios#2809.

@tobiasKaminsky I think we should enable automatic migration for E2EE folders with nested folders on desktop.

[allexzander]

/backport to stable-3.13

[allexzander]

/backport to stable-3.12

[mgallien]

could you have a look at adding automated tests via the end-to-end tests with a real running server ?
@tobiasKaminsky in the end up to you if Alex has time to add those automated tests

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6695-0f87fd4a715b975df7431f41778faaceb17ca7d6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
46 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[Rello]

@tobiasKaminsky another ping if this is really wanted or if you see any risks?
thank you

[tobiasKaminsky]

@tobiasKaminsky another ping if this is really wanted or if you see any risks?

v2 will be used for any new created folder, so we should also migrate v1.
iOS and Android do the same.

So, ✔ for general approach/idea.

[mgallien]

apparently no compatibility issue expected
let's merge it asap

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-6695.zip

SHA256 checksum: c3e049380252184b33d52b6f3822f91da17a119d4c7075e965d4a9b1940333a3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
49 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE