Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.8] Fix unit tests SecureFileDrop #5578

Merged
merged 1 commit into from
Apr 7, 2023
Merged

[stable-3.8] Fix unit tests SecureFileDrop #5578

merged 1 commit into from
Apr 7, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5574

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.8.1 milestone Apr 5, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Apr 5, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (stable-3.8@03fe1a4). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff              @@
##             stable-3.8    #5578   +/-   ##
=============================================
  Coverage              ?   59.25%           
=============================================
  Files                 ?      143           
  Lines                 ?    18435           
  Branches              ?        0           
=============================================
  Hits                  ?    10924           
  Misses                ?     7511           
  Partials              ?        0

@allexzander
Fix unit tests SecureFileDrop
76b2f56 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the backport/5574/stable-3.8 branch from 151d09c to 76b2f56 Compare April 7, 2023 08:09
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5578-76b2f566f00ce36687b56e141b335f8e022291f8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 22b0540 into stable-3.8 Apr 7, 2023
@allexzander allexzander deleted the backport/5574/stable-3.8 branch April 7, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nextcloud-desktop-bot @allexzander