Fix two factor auth notification: activity item was disabled. #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User couldn't click on the links. Signed-off-by: Camila <hello@camila.codes>
|
AppImage file: nextcloud-PR-4961-7db68ad2c5736d632e3da3d5ec716219499cda01-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4961 +/- ##
==========================================
+ Coverage 56.99% 57.13% +0.13%
==========================================
Files 138 138
Lines 17232 17232
==========================================
+ Hits 9821 9845 +24
+ Misses 7411 7387 -24
|
claucambra
approved these changes
Sep 21, 2022
|
/backport to stable-3.6 |
|
/backport to stable-3.6 |
|
The backport to stable-3.6 failed. Please do this backport manually. |
|
/backport to stable-3.6 |
|
The backport to stable-3.6 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User couldn't click on it.
Before:
After:
Noticed after looking into #4841. Could reproduce it on Linux and Windows.