Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QML warnings #4818

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix QML warnings #4818

merged 1 commit into from
Aug 9, 2022

Conversation

claucambra
Copy link
Collaborator

This PR fixes some QML warnings originating from a typo and a signal that had its name changed on the C++ side

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Aug 4, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@allexzander allexzander force-pushed the bugfix/qml-warnings branch from 4f74094 to 0a89bf2 Compare August 9, 2022 11:45
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4818-0a89bf2335bb683a2cfaafafbc00fe32c713d7eb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4818 (0a89bf2) into master (ec2bba7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   57.22%   57.21%   -0.02%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
- Hits         9811     9809       -2     
- Misses       7333     7335       +2     
Impacted Files Coverage Δ
src/libsync/ocsuserstatusconnector.cpp 6.09% <0.00%> (ø)
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.25% <0.00%> (-0.46%) ⬇️

@claucambra claucambra merged commit ad7a72a into master Aug 9, 2022
@claucambra claucambra deleted the bugfix/qml-warnings branch August 9, 2022 12:40
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants