Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use basic authentication if needed #3885

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Only use basic authentication if needed #3885

merged 1 commit into from
Oct 18, 2021

Conversation

FlexW
Copy link

@FlexW FlexW commented Oct 12, 2021

No description provided.

@FlexW FlexW requested a review from er-vin October 12, 2021 09:00
@FlexW
Copy link
Author

FlexW commented Oct 12, 2021

@er-vin We had issues with a customer that used SAML for authentication. I've tested that the changes don't break basic authentication. Regardless, I would appreciate your feedback.

@FlexW FlexW marked this pull request as draft October 12, 2021 09:03
er-vin
er-vin approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@er-vin er-vin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@FlexW FlexW marked this pull request as ready for review October 14, 2021 08:40
mgallien
mgallien approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mgallien
Copy link
Collaborator

/rebase

Only use basic authentication if needed
24f6bc5 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
@FlexW FlexW force-pushed the bugfix/saml-login branch from 35979ae to 24f6bc5 Compare October 18, 2021 10:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3885-24f6bc5203aff4f5d434c17685e1c94a9e1dd915-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@FlexW FlexW merged commit 3c749bd into master Oct 18, 2021
@FlexW FlexW deleted the bugfix/saml-login branch October 18, 2021 13:38
@FlexW
Copy link
Author

FlexW commented Oct 18, 2021

/backport to stable-3.3

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 18, 2021
Merged
@mgallien mgallien added this to the 3.4.0 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@er-vin er-vin er-vin approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FlexW @mgallien @nextcloud-desktop-bot @er-vin