Skip to content

Commit

Permalink
Enable netrc tests
Browse files Browse the repository at this point in the history
Test for spaces in usernames and passwords is disabled for now as it's
not supported by current implementation.

Signed-off-by: Fredrik Eriksson <feffe@fulh.ax>
  • Loading branch information
fredrik-eriksson authored and mgallien committed Jan 3, 2025
1 parent 65db9a0 commit 294bb1a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/testnetrcparser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ private slots:

void testValidNetrc() {
NetrcParser parser(testfileC);
QEXPECT_FAIL("", "test currently broken, eventually will be fixed", Abort);
QVERIFY(parser.parse());
QCOMPARE(parser.find("foo"), qMakePair(QString("bar"), QString("baz")));
QCOMPARE(parser.find("broken"), qMakePair(QString("bar2"), QString()));
QCOMPARE(parser.find("funnysplit"), qMakePair(QString("bar3"), QString("baz3")));
QEXPECT_FAIL("", "Current implementation do not support spaces in username or password", Continue);
QCOMPARE(parser.find("frob"), qMakePair(QString("user with spaces"), QString("space pwd")));
}

Expand All @@ -69,7 +69,6 @@ private slots:

void testValidNetrcWithDefault() {
NetrcParser parser(testfileWithDefaultC);
QEXPECT_FAIL("", "test currently broken, eventually will be fixed", Abort);
QVERIFY(parser.parse());
QCOMPARE(parser.find("foo"), qMakePair(QString("bar"), QString("baz")));
QCOMPARE(parser.find("dontknow"), qMakePair(QString("user"), QString("pass")));
Expand Down

0 comments on commit 294bb1a

Please sign in to comment.