Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix deleted card/board issues #5444

Merged
merged 10 commits into from
Jan 12, 2024
Merged

[stable25] Fix deleted card/board issues #5444

merged 10 commits into from
Jan 12, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 9, 2024 •
edited
Loading

Backport of #5423

@juliusknorr juliusknorr changed the title [stable25] [stable26] Fix deleted card/board issues [stable25] Fix deleted card/board issues Jan 9, 2024
@cypress Cypress
Copy link

cypress bot commented Jan 9, 2024 •
edited
Loading

Passing run #1742 ↗︎

0 6 0 0 Flakiness 0

Details:

Merge d078055 into 041f3e6...
Project: Deck Commit: 1ec132fa92 ℹ️
Status: Passed Duration: 01:25 💡
Started: Jan 12, 2024 7:57 AM Ended: Jan 12, 2024 7:58 AM

Review all test suite changes for PR #5444 ↗︎

@juliusknorr juliusknorr force-pushed the backport/5443/stable25 branch from 9b8194b to 6b12873 Compare January 9, 2024 22:44
@juliusknorr
tests: Add integration tests for deleted boards/cards
8f58923 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Consider a deleted board inaccessible to share recipients
0374693 
Only the owner can delete/undo a board deletion so there is no reason
other users should have any permission on a board marked as deleted

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: limit to non-deleted cards
e75ff1c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Further limit updating cards
aa7430b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Limit card activities for deleted cards
6e3762e 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
chore: Fix ci setup for activity
ce84bd6 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
tests: Fix missing behat context methods
8efa30d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: PHP 7.4 compatibility
e56b278 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
ci: Update actions
8915c14 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
test: Adapt unit tests
d078055 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/5443/stable25 branch from bb6e977 to d078055 Compare January 12, 2024 07:45
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 79465 was 68024 (+16.81%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 79432 was 68024 (+16.77%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@juliusknorr juliusknorr merged commit c69b1c6 into stable25 Jan 12, 2024
25 checks passed
@juliusknorr juliusknorr deleted the backport/5443/stable25 branch January 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juliusknorr