Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust spacing and alignment in the contact details view #4041

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 18, 2024

fix #4018

b a
image image

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 added 3. to review Waiting for reviews design Related to the design labels Jul 18, 2024
@hamza221 hamza221 requested review from st3iny and GretaD July 18, 2024 16:03
@hamza221 hamza221 self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (55f94ef) to head (75ee842).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4041   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@ChristophWurst ChristophWurst merged commit 8a9558c into main Jul 18, 2024
26 checks passed
@ChristophWurst ChristophWurst deleted the fix/contact-details-spacing branch July 18, 2024 17:27
@nimishavijay
Copy link
Member

The spacing between the actions and the contact name/org details is too less now! I meant something like this

image

@ChristophWurst
Copy link
Member

@nimishavijay we did this intentionally because the quick actions are floating with no alignment to any other actions. Now they are clearly part of the header with the summary information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact details properties alignment and spacing
3 participants