-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libglib-2.0.so.0 and libgobject-2.0.so.0 from Appimage (Avoid libsecret breakage) #105
Conversation
@FredericLespez thank you for providing the PR as a workaround as described in the linked issue over at linuxdeployqt and this would hopefully fix this prominent issue #4715. i saw that the checks failed, if you click on details of the DCO, it claims that your commit message did not contain the required "signed-off" part and describes how you can add it. maybe this helps to bring this PR further? |
ff4649f
to
fee1044
Compare
@x29a Sorry, i didn't see that a "signed-off" was required. It's OK now. |
I verified your PR by running https://github.com/nextcloud/client-building/blob/master/linux/build-daily.sh on an Ubuntu 22.04.1 and the resulting appImage works great. It even logs into the accounts that were previously logged out. As i cant contribute to your code changes i hope somebody with deeper insights and feedback will pick this up soon! |
…t support) from Appimage Signed-off-by: Frédéric Lespez <frederic.lespez@free.fr>
fee1044
to
e34e255
Compare
I made another version of this PR. |
I can confirm that this PR fixes the authorization issue with the Nextcloud Client AppImage. @mgallien would you be able to look over the pull request? |
if that is the case, https://github.com/nextcloud/desktop/blob/master/admin/linux/build-appimage.sh also needs this change. |
…libsecret breakage) Patch from contributor at nextcloud/client-building/pull/105. Signed-off-by: Camila <hello@camila.codes>
Patch from contributor at nextcloud/client-building/pull/105. Signed-off-by: Camila <hello@camila.codes>
Patch from contributor at nextcloud/client-building/pull/105. Signed-off-by: Camila <hello@camila.codes>
Patch from contributor at nextcloud/client-building/pull/105. Signed-off-by: Camila <hello@camila.codes>
The latest version of linuxdeployqt bundles libglib-2.0.so.0 and libgobject-2.0.so.0 inside the Nextcloud Client AppImage.
This breaks libsecret support.
This PR remove libglib-2.0.so.0 and libgobject-2.0.so.0 from the AppImage generated by linuxdeployqt.
It is another way to workaround issue #103.