Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libglib-2.0.so.0 and libgobject-2.0.so.0 from Appimage (Avoid libsecret breakage) #105

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

FredL69
Copy link

@FredL69 FredL69 commented Aug 4, 2022

The latest version of linuxdeployqt bundles libglib-2.0.so.0 and libgobject-2.0.so.0 inside the Nextcloud Client AppImage.
This breaks libsecret support.
This PR remove libglib-2.0.so.0 and libgobject-2.0.so.0 from the AppImage generated by linuxdeployqt.
It is another way to workaround issue #103.

@x29a
Copy link

x29a commented Aug 5, 2022

@FredericLespez thank you for providing the PR as a workaround as described in the linked issue over at linuxdeployqt and this would hopefully fix this prominent issue #4715.

i saw that the checks failed, if you click on details of the DCO, it claims that your commit message did not contain the required "signed-off" part and describes how you can add it. maybe this helps to bring this PR further?

@FredL69 FredL69 force-pushed the workaround_issue_103_alt branch from ff4649f to fee1044 Compare August 5, 2022 08:51
@FredL69
Copy link
Author

FredL69 commented Aug 5, 2022

@x29a Sorry, i didn't see that a "signed-off" was required. It's OK now.

@x29a
Copy link

x29a commented Aug 5, 2022

I verified your PR by running https://github.com/nextcloud/client-building/blob/master/linux/build-daily.sh on an Ubuntu 22.04.1 and the resulting appImage works great. It even logs into the accounts that were previously logged out.

As i cant contribute to your code changes i hope somebody with deeper insights and feedback will pick this up soon!

…t support) from Appimage

Signed-off-by: Frédéric Lespez <frederic.lespez@free.fr>
@FredL69 FredL69 force-pushed the workaround_issue_103_alt branch from fee1044 to e34e255 Compare August 5, 2022 15:53
@FredL69
Copy link
Author

FredL69 commented Aug 5, 2022

I made another version of this PR.
Instead of downloading the AppImage of appimagetool, I use the appimagetool bundled with linuxdeployqt.

@zevlee
Copy link

zevlee commented Aug 9, 2022

I can confirm that this PR fixes the authorization issue with the Nextcloud Client AppImage.

@mgallien would you be able to look over the pull request?

@camilasan
Copy link
Member

if that is the case, https://github.com/nextcloud/desktop/blob/master/admin/linux/build-appimage.sh also needs this change.

@allexzander allexzander merged commit a47bc3e into nextcloud:master Aug 9, 2022
camilasan pushed a commit to nextcloud/desktop that referenced this pull request Aug 9, 2022
…libsecret breakage)

Patch from contributor at nextcloud/client-building/pull/105.

Signed-off-by: Camila <hello@camila.codes>
camilasan pushed a commit to nextcloud/desktop that referenced this pull request Aug 9, 2022
Patch from contributor at nextcloud/client-building/pull/105.

Signed-off-by: Camila <hello@camila.codes>
camilasan pushed a commit to nextcloud/desktop that referenced this pull request Aug 9, 2022
Patch from contributor at nextcloud/client-building/pull/105.

Signed-off-by: Camila <hello@camila.codes>
tokun-mobica pushed a commit to tokun-mobica/desktop that referenced this pull request Sep 11, 2022
Patch from contributor at nextcloud/client-building/pull/105.

Signed-off-by: Camila <hello@camila.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants