Add OCI ci and make tests not silently failing

.github/workflows/phpunit.yml

@@ -200,3 +200,64 @@ jobs:
       # - name: PHPUnit integration
       #   working-directory: apps/${{ env.APP_NAME }}
       #   run: ./vendor/phpunit/phpunit/phpunit -c phpunit.integration.xml
+
+  oci:
+    runs-on: ubuntu-latest
+
+    strategy:
+      # do not stop on another job's failure
+      fail-fast: false
+      matrix:
+        php-versions: ['7.4']
+        databases: ['oci']
+
+    name: php${{ matrix.php-versions }}-${{ matrix.databases }}
+
+    services:
+      oracle:
+        image: deepdiver/docker-oracle-xe-11g # "wnameless/oracle-xe-11g-r2"
+        ports:
+          - "1521:1521"
+
+    steps:
+      - name: Checkout server
+        uses: actions/checkout@v2
+        with:
+          repository: nextcloud/server
+          ref: ${{ env.GITHUB_BASE_REF }}
+
+      - name: Checkout submodules
+        shell: bash
+        run: |
+          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
+          git submodule sync --recursive
+          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
+
+      - name: Checkout app
+        uses: actions/checkout@v2
+        with:
+          path: apps/${{ env.APP_NAME }}
+
+      - name: Set up php ${{ matrix.php-versions }}
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "${{ matrix.php-versions }}"
+          extensions: mbstring, iconv, fileinfo, intl, oci8
+          tools: phpunit:8.5.2
+          coverage: none
+
+      - name: Set up PHPUnit
+        working-directory: apps/${{ env.APP_NAME }}
+        run: composer i
+
+      - name: Set up Nextcloud
+        run: |
+          mkdir data
+          ./occ maintenance:install --verbose --database=oci --database-name=XE --database-host=127.0.0.1 --database-port=1521 --database-user=autotest --database-pass=owncloud --admin-user admin --admin-pass admin
+          php -f index.php
+          ./occ app:enable --force ${{ env.APP_NAME }}
+          php -S localhost:8080 &
+
+      - name: PHPUnit
+        working-directory: apps/${{ env.APP_NAME }}/tests
+        run: ../vendor/phpunit/phpunit/phpunit -c phpunit.xml

lib/Db/CircleRequestBuilder.php

@@ -112,6 +112,8 @@ public function getItemFromRequest(CoreQueryBuilder $qb): Circle {
 			$circle = $qb->asItem(Circle::class);
 		} catch (RowNotFoundException $e) {
 			throw new CircleNotFoundException('Circle not found');
+		} catch (\Exception $e) {
+			throw new \Exception($qb->getSQL());
 		}
 
 		return $circle;

lib/Db/CoreQueryBuilder.php

@@ -56,30 +56,29 @@ class CoreQueryBuilder extends ExtendedQueryBuilder {
 	use TArrayTools;
 
 
-	public const SINGLE = 'single';
-	public const CIRCLE = 'circle';
-	public const MEMBER = 'member';
-	public const MEMBER_COUNT = 'membercount';
-	public const OWNER = 'owner';
-	public const FEDERATED_EVENT = 'federatedevent';
-	public const REMOTE = 'remote';
-	public const BASED_ON = 'basedon';
-	public const INITIATOR = 'initiator';
-	public const DIRECT_INITIATOR = 'initiatordirect';
-	public const MEMBERSHIPS = 'memberships';
-	public const CONFIG = 'config';
-	public const UPSTREAM_MEMBERSHIPS = 'upstreammemberships';
-	public const INHERITANCE_FROM = 'inheritancefrom';
-	public const INHERITED_BY = 'inheritedby';
-	public const INVITED_BY = 'invitedby';
-	public const MOUNT = 'mount';
-	public const MOUNTPOINT = 'mountpoint';
-	public const SHARE = 'share';
-	public const FILE_CACHE = 'filecache';
-	public const STORAGES = 'storages';
-	public const TOKEN = 'token';
-	public const OPTIONS = 'options';
-	public const HELPER = 'circleshelper';
+	public const SINGLE = 'cs';
+	public const CIRCLE = 'cc';
+	public const MEMBER = 'mm';
+	public const OWNER = 'wn';
+	public const FEDERATED_EVENT = 'ev';
+	public const REMOTE = 'rm';
+	public const BASED_ON = 'on';
+	public const INITIATOR = 'in';
+	public const DIRECT_INITIATOR = 'di';
+	public const MEMBERSHIPS = 'ms';
+	public const CONFIG = 'cf';
+	public const UPSTREAM_MEMBERSHIPS = 'up';
+	public const INHERITANCE_FROM = 'ih';
+	public const INHERITED_BY = 'by';
+	public const INVITED_BY = 'nv';
+	public const MOUNT = 'mo';
+	public const MOUNTPOINT = 'mp';
+	public const SHARE = 'sh';
+	public const FILE_CACHE = 'fc';
+	public const STORAGES = 'st';
+	public const TOKEN = 'tk';
+	public const OPTIONS = 'pt';
+	public const HELPER = 'hp';
 
 
 	public static $SQL_PATH = [
@@ -90,7 +89,6 @@ class CoreQueryBuilder extends ExtendedQueryBuilder {
 			self::OPTIONS => [
 			],
 			self::MEMBER,
-			self::MEMBER_COUNT,
 			self::OWNER => [
 				self::BASED_ON
 			],

lib/Migration/Version0023Date20211216113101.php

@@ -47,5 +47,4 @@ class Version0023Date20211216113101 extends SimpleMigrationStep {
 	 */
 	public function __construct(IDBConnection $connection) {
 	}
-
 }

lib/Migration/Version0024Date20220203123901.php

@@ -69,8 +69,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 			$table = $schema->getTable('circles_token');
 			$table->changeColumn(
 				'password', [
-							  'length' => 127
-						  ]
+					'length' => 127
+				]
 			);
 		}
 
@@ -105,5 +105,4 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 
 		return $schema;
 	}
-
 }

lib/Migration/Version0024Date20220203123902.php

@@ -64,67 +64,66 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 			$table = $schema->createTable('circles_event');
 			$table->addColumn(
 				'token', 'string', [
-						   'notnull' => false,
-						   'length' => 63,
-					   ]
+					'notnull' => false,
+					'length' => 63,
+				]
 			);
 			$table->addColumn(
 				'event', 'text', [
-						   'notnull' => false
-					   ]
+					'notnull' => false
+				]
 			);
 			$table->addColumn(
 				'result', 'text', [
-							'notnull' => false
-						]
+					'notnull' => false
+				]
 			);
 			$table->addColumn(
 				'instance', 'string', [
-							  'length' => 255,
-							  'notnull' => false
-						  ]
+					'length' => 255,
+					'notnull' => false
+				]
 			);
 			$table->addColumn(
 				'interface', 'integer', [
-							   'notnull' => true,
-							   'length' => 1,
-							   'default' => 0
-						   ]
+					'notnull' => true,
+					'length' => 1,
+					'default' => 0
+				]
 			);
 			$table->addColumn(
 				'severity', 'integer', [
-							  'length' => 3,
-							  'notnull' => false
-						  ]
+					'length' => 3,
+					'notnull' => false
+				]
 			);
 			$table->addColumn(
 				'retry', 'integer', [
-						   'length' => 3,
-						   'notnull' => false
-					   ]
+					'length' => 3,
+					'notnull' => false
+				]
 			);
 			$table->addColumn(
 				'status', 'integer', [
-							'length' => 3,
-							'notnull' => false
-						]
+					'length' => 3,
+					'notnull' => false
+				]
 			);
 			$table->addColumn(
 				'updated', 'datetime', [
-							 'notnull' => false,
-						 ]
+					'notnull' => false,
+				]
 			);
 			$table->addColumn(
 				'creation', 'bigint', [
-							  'length' => 14,
-							  'notnull' => false
-						  ]
+					'length' => 14,
+					'notnull' => false
+				]
 			);
 
 			$table->setPrimaryKey(['token', 'instance']);
 		}
 
 		return $schema;
 	}
-
 }

lib/Migration/Version0024Date20220317190331.php

@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+
+/**
+ * Circles - Bring cloud-users closer together.
+ *
+ * This file is licensed under the Affero General Public License version 3 or
+ * later. See the COPYING file.
+ *
+ * @author Maxence Lange <maxence@artificial-owl.com>
+ * @copyright 2022
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+
+namespace OCA\Circles\Migration;
+
+use Closure;
+use Doctrine\DBAL\Schema\SchemaException;
+use OCP\DB\ISchemaWrapper;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version0024Date20220317190331 extends SimpleMigrationStep {
+
+	/**
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+	 * @param array $options
+	 *
+	 * @return null|ISchemaWrapper
+	 * @throws SchemaException
+	 */
+	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+		/** @var ISchemaWrapper $schema */
+		$schema = $schemaClosure();
+
+		if ($schema->hasTable('circles_membership')) {
+			$table = $schema->getTable('circles_membership');
+			if (!$table->hasPrimaryKey()) {
+				$indexes = $table->getIndexes();
+				// conflict in Oracle with existing unique index, duplicate of primaryKey.
+				foreach ($indexes as $index) {
+					if ($index->isUnique()) {
+						$table->dropIndex($index->getName());
+					}
+				}
+				$table->setPrimaryKey(['single_id', 'circle_id']);
+			}
+		}
+
+		return $schema;
+	}
+}