PropertyColor: now color is selected with submit button instead of directly #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of directly Signed-off-by: Grigory V <scratchx@gmx.com>
ChristophWurst
approved these changes
Jul 24, 2024
| * but the RFC 7986 property COLOR requires | ||
| * css-color-names. | ||
| * | ||
| * The color-space of css-color-names is smaller |
There was a problem hiding this comment.
We don't need debounce because submit happens only once?
There was a problem hiding this comment.
Yep and it doesn't happen immediately after choosing the color
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6200 +/- ##
============================================
- Coverage 23.93% 23.67% -0.26%
Complexity 457 457
============================================
Files 247 249 +2
Lines 11627 11774 +147
Branches 2196 2204 +8
============================================
+ Hits 2783 2788 +5
- Misses 8527 8669 +142
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6145
Based on @st3iny's idea #6145 (comment)