-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language selection to attendee section #590
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f54650e
Add language selection to attendee section
d98187e
Change lang to language
fcf8ae9
Partially Revert "Change lang to language"
18f47bf
Fix active language issue
495bac0
Fix overlap issue
8238915
Fix lang to language in iCal
77f27d2
Remove stuff we now have outsourced
2e4670f
Add langauage parameter to unit tests
8fa6d41
Remove whitespace to ignore conflict
9202560
Solved conflicts
9a8f699
Add missing method argument
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,7 +62,8 @@ app.controller('AttendeeController', function($scope, AutoCompletionService) { | |
'role': 'REQ-PARTICIPANT', | ||
'rsvp': 'TRUE', | ||
'partstat': 'NEEDS-ACTION', | ||
'cutype': 'INDIVIDUAL' | ||
'cutype': 'INDIVIDUAL', | ||
'language': OC.getLocale() // Use current user's timezone as a default value | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of OC.getLocale() for the default value the default should be the value of the user value 'core' 'lang'. When loading the page this can be added to the parameters by retrieving $this->config->getUserValue($user->getUID(), 'core', 'lang'); in viewcontroller.php. |
||
} | ||
}); | ||
} | ||
|
@@ -96,7 +97,8 @@ app.controller('AttendeeController', function($scope, AutoCompletionService) { | |
arr.push({ | ||
displayname: displayname, | ||
email: email, | ||
name: attendee.name | ||
name: attendee.name, | ||
language: attendee.language | ||
}); | ||
}); | ||
}); | ||
|
@@ -114,7 +116,8 @@ app.controller('AttendeeController', function($scope, AutoCompletionService) { | |
role: 'REQ-PARTICIPANT', | ||
rsvp: 'TRUE', | ||
partstat: 'NEEDS-ACTION', | ||
cutype: 'INDIVIDUAL' | ||
cutype: 'INDIVIDUAL', | ||
language: item.language | ||
} | ||
}); | ||
$scope.nameofattendee = ''; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does
$userId
come from? It's not injected into the controller.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, it's inside the current scope. Everthing's fine! :)