-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps and use npm7 #319
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
03c075f
to
ca9b76d
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration works fine for Tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Works for notes, see nextcloud/notes#727
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nextcloud/forms#987
Just for information: if you use node v15, you do not need to explicitly install npm v7, since it's already included. This simplifies the GitHub workflow a little bit. |
Node lts is still 14 :) |
One issue I encountered! |
announcementcenter works: nextcloud/announcementcenter#360 |
user retention works: nextcloud/user_retention#361 |
@skjnldsv I think nextcloud-vue is does not have a PR for npm7 yet, right (just asking because it's checked in the list)? |
Ah sorry, I thought nextcloud-libraries/nextcloud-vue#2037 was it, indeed! 👍 |
Yes, I was about to try that yesterday already, but thought it would be cleaner to first merge the common webpack config 😃 |
Registration works: nextcloud/registration#309 |
Ok, let's go then, the process seems to be going well? |
@korelstar @raimund-schluessler @jotoeri @juliushaertl @artonge @eneiluj @ChristophWurst "engines": {
"node": ">=14.0.0",
"npm": ">=7.0.0"
}, |
Collectives app also migrated now. Thanks a lot for the detailed instructions @skjnldsv! Since in our case some extra steps were necessary (in order to make the CI work again), here's the link to our merge request for future reference: https://gitlab.com/collectivecloud/collectives/-/merge_requests/301 |
Please test on your respective apps and see what's breaking⚠️
(list built automatically, feel free to remove unrelated entries)
npm i -D @nextcloud/webpack-vue-config@latest @nextcloud/eslint-config@latest @nextcloud/babel-config@latest @nextcloud/browserslist-config@latest @nextcloud/stylelint-config@latest
@nextcloud/webpack-vue-config
and use npm7 calendar#3215nextcloud-vueBlocked by webpack 4serverWill be the exception until Nextcloud 23 for safety reasons