Fix a bug in nc_apache2.j2 template concerning intermed-CA. Remove an… #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible-lint warnings and add config-variable needed for SSO to nc_apache2.j2 template. Signed-off-by: marioqxx <marioqxx@users.noreply.github.com>
Signed-off-by: marioqxx <marioqxx@users.noreply.github.com>
|
Hi! These changes for TLS certs looks good, but I think we shouldn't change |
wiktor2200
requested changes
Jun 22, 2023
I also prefer that the whole code has consistent modes, good point. |
Sure. I chanced to this notiation, because of ansible-lint warnings on my computer. Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com> Signed-off-by: marioqxx <82337956+marioqxx@users.noreply.github.com>
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com> Signed-off-by: marioqxx <82337956+marioqxx@users.noreply.github.com>
wiktor2200
requested changes
Jun 26, 2023
|
@wiktor2200 @marioqxx after this one we can release 2.1.0 ;) |
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com> Signed-off-by: marioqxx <82337956+marioqxx@users.noreply.github.com>
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com> Signed-off-by: marioqxx <82337956+marioqxx@users.noreply.github.com>
wiktor2200
approved these changes
Jun 28, 2023
|
@marioqxx Approved and merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sible-lint warnings and add config-variable needed for SSO to nc_apache2.j2 template. The diff in tls_signed.yml looks a bit wired, as the change involved swapping two tasks only and adding some "when" conditionals.