Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pre-commit update flow #236

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

wiktor2200
Copy link
Collaborator

Regarding Issue #234

@wiktor2200 wiktor2200 added ci Continuous Integration pre-commit Pull requests that update pre-commit code labels Mar 16, 2023
@wiktor2200 wiktor2200 force-pushed the change-precommit-update-flow branch from 25253d7 to 1b63e8e Compare March 17, 2023 10:43
Signed-off-by: wiktor2200 <wiktor2200@users.noreply.github.com>
Signed-off-by: wiktor2200 <wiktor2200@users.noreply.github.com>
@wiktor2200 wiktor2200 force-pushed the change-precommit-update-flow branch from 1b63e8e to b4661bc Compare March 17, 2023 10:46
@wiktor2200
Copy link
Collaborator Author

Hi @staticdev @aalaesar!
I've seen that there was an update in apparmor repo.
But official Debian10 in Gitlab Actions wasn't updated for some reason. I've added apt-get update command to fix that.

BTW, this DCO check is kind of annoying. I've GPG signed commits turned on by default (set up by git config), but unfortunately there is no option to do the same for sign-off.
Do you have any suggestions/ideas how we can improve that? Because even simple --amend re-triggers pipelines, so they are run in vain.

@aalaesar
Copy link
Member

Hi @staticdev @aalaesar! I've seen that there was an update in apparmor repo. But official Debian10 in Gitlab Actions wasn't updated for some reason. I've added apt-get update command to fix that.

Ok thank you.

BTW, this DCO check is kind of annoying. I've GPG signed commits turned on by default (set up by git config), but unfortunately there is no option to do the same for sign-off. Do you have any suggestions/ideas how we can improve that? Because even simple --amend re-triggers pipelines, so they are run in vain.

hmm maybe putting a dependency for the DCO on the tests not sure if possible

Copy link
Member

@aalaesar aalaesar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wiktor2200 wiktor2200 merged commit 6fafe7a into nextcloud:main Mar 20, 2023
@wiktor2200 wiktor2200 deleted the change-precommit-update-flow branch March 20, 2023 17:23
@wiktor2200 wiktor2200 added the skip-changelog This will not be added to release notes label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration pre-commit Pull requests that update pre-commit code skip-changelog This will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants