Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page #9112

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Profile page #9112

merged 1 commit into from
Oct 25, 2021

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 20, 2021

Fix #9097
For: nextcloud/files-clients#1

TODO

  • find out where we also should show profile

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #9112 (6d07584) into master (6bdfe17) will decrease coverage by 0.11%.
The diff coverage is 4.95%.

@@            Coverage Diff             @@
##           master    #9112      +/-   ##
==========================================
- Coverage   31.33%   31.21%   -0.12%     
==========================================
  Files         464      466       +2     
  Lines       35959    36075     +116     
  Branches     4923     4930       +7     
==========================================
- Hits        11267    11261       -6     
- Misses      23102    23219     +117     
- Partials     1590     1595       +5     
Impacted Files Coverage Δ
...m/owncloud/android/ui/adapter/ShareViewHolder.java 0.00% <0.00%> (ø)
...roid/ui/asynctasks/RetrieveHoverCardAsyncTask.java 0.00% <0.00%> (ø)
...android/ui/fragment/FileDetailSharingFragment.java 32.70% <0.00%> (-0.32%) ⬇️
...ud/android/ui/fragment/ProfileBottomSheetDialog.kt 0.00% <0.00%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 32.12% <0.00%> (-0.53%) ⬇️
...owncloud/android/ui/adapter/ShareeListAdapter.java 58.33% <66.66%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 38.36% <100.00%> (-0.62%) ⬇️
.../owncloud/android/datamodel/MediaFoldersModel.java 0.00% <0.00%> (-40.00%) ⬇️
...nextcloud/client/jobs/MediaFoldersDetectionWork.kt 8.75% <0.00%> (-8.03%) ⬇️
...xtcloud/client/onboarding/OnboardingServiceImpl.kt 59.09% <0.00%> (-4.55%) ⬇️
... and 11 more

@tobiasKaminsky tobiasKaminsky force-pushed the profilePage branch 2 times, most recently from 2969ab0 to 6ee9597 Compare October 25, 2021 10:54
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9112.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings112112
Errors11

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 50
Internationalization Warnings 9
Malicious code vulnerability Warnings 53
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 40
Dodgy code Warnings 98
Total 355

SpotBugs (master)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 50
Internationalization Warnings 9
Malicious code vulnerability Warnings 53
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 40
Dodgy code Warnings 98
Total 355

@github-actions
Copy link

@tobiasKaminsky tobiasKaminsky merged commit d544e18 into master Oct 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the profilePage branch October 25, 2021 13:07
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.18.0 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile page
4 participants