Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resized images #69

Closed
wants to merge 87 commits into from
Closed

Resized images #69

wants to merge 87 commits into from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 25, 2016

What it does, copied from ownCloud and heavily discussed there, so here just a CR:

  • Clicking on an image loads a reduced version to the cache.
  • The width and height is determinated by the screen.
  • the benefit is a very small, but yet usable preview of the image.
  • it can be used to send via whatsapp, or as a file to another app (like k9) with the correct filename.
  • resized images are not treated as downloaded files. If the user wants to have the real file, he has to long-click and select download.
  • clicking on an image shows first a square thumbnail (if available) until the resized image is loaded

ToDo

  • test with disabled API (gallery app)
    • test if thumbnails api can be used -> not possible right now
  • Unsupported image formats Resized images owncloud/android#1599 (comment)
    • svg
    • tiff
  • Bad preview of landscape images Resized images owncloud/android#1599 (comment) [WIP]
  • sharing a non-downloaded image on Android N fails (at least with whatsapp)
  • sharing a non-cached resized image fails -> first download resized version
  • a resized image should load immediately (first on queue or dismiss all other current downloads)
  • download of a resized image also with a nice download animation on the bottom?
  • snackbar is sometimes beneath virtual keys
  • if resized version show "sending resized image" otherwise "send" (as it is now)
  • test with disabled data
    • show resized image if available
    • show thumbnail if resized image not available
    • show (something smart) if both is not available -> default image icon
  • on air plane mode: snackbar is shown all the time as resized download files -> prior check of connection

Assumptions:

  • users do not want to download the whole image, instead just like streaming have only a resized version
  • if an user wants to have many images in original quality, he can synchronize the folder

This leads us to

  • always show a resized version
  • if an user zooms in (> 2x) a snackbar "download full image: yes" will be shown (on every time)
  • (to have the old behaviour: add setting "click on image downloads full image" (as checkbox))

Update: Talked to Jan @conf:

  • behvaviour setting can be removed
  • otherwise approved

AndyScherzinger and others added 3 commits August 10, 2017 19:27
…sizedImages

# Conflicts:
#	src/main/res/values-cs-rCZ/strings.xml
#	src/main/res/values-de-rDE/strings.xml
#	src/main/res/values-de/strings.xml
#	src/main/res/values-el/strings.xml
#	src/main/res/values-en-rGB/strings.xml
#	src/main/res/values-es-rMX/strings.xml
#	src/main/res/values-es/strings.xml
#	src/main/res/values-fi-rFI/strings.xml
#	src/main/res/values-fr/strings.xml
#	src/main/res/values-is/strings.xml
#	src/main/res/values-it/strings.xml
#	src/main/res/values-nb-rNO/strings.xml
#	src/main/res/values-nl/strings.xml
#	src/main/res/values-pl/strings.xml
#	src/main/res/values-pt-rBR/strings.xml
#	src/main/res/values-ru/strings.xml
#	src/main/res/values-sq/strings.xml
#	src/main/res/values-tr/strings.xml
#	src/main/res/values-zh-rCN/strings.xml
#	src/main/res/values/strings.xml
@nextcloud nextcloud deleted a comment Aug 10, 2017
@nextcloud nextcloud deleted a comment Aug 11, 2017
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Oct 24, 2017

Closing in favor of #1710
Please do not yet delete the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants