-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Thumbnails): Use local id rather than remote id #14081
Conversation
/backport to stable-3.29 |
/backport to stable-3.30 |
5602efc
to
dede489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't notice anything wrong. Thumbnails are generated without any issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing, I haven't been able to reproduce the problem with this fix in place.
Thank you for fixing this!
Fixes #13743 Signed-off-by: Josh <josh.t.richards@gmail.com>
dede489
to
1d23c3a
Compare
The backport to # Switch to the target branch and update it
git checkout stable-3.29
git pull origin stable-3.29
# Create the new backport branch
git checkout -b backport/14081/stable-3.29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1d23c3a4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14081/stable-3.29 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","field":"base","code":"invalid"} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This should the scenarios described in #13743
May also fix #13515 and #13989
It's a regression from #13164 where the wrong DAV property (
id
/ remote id) was used instead offileid
/ local id) for some thumbnail retrievals.Looks like the bug made its way into >= 3.30.0 + (via backport) 3.29.3 aka "3.29.2"