Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Thumbnails): Use local id rather than remote id #14081

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Nov 23, 2024

This should the scenarios described in #13743
May also fix #13515 and #13989

It's a regression from #13164 where the wrong DAV property (id / remote id) was used instead of fileid / local id) for some thumbnail retrievals.

Looks like the bug made its way into >= 3.30.0 + (via backport) 3.29.3 aka "3.29.2"

  • Tests written, or not not needed

@joshtrichards
Copy link
Member Author

/backport to stable-3.29

@joshtrichards
Copy link
Member Author

/backport to stable-3.30

@joshtrichards joshtrichards changed the title fix(Thumbnails): Use correct local id rather than remote id fix(Thumbnails): Use local id rather than remote id Nov 23, 2024
@joshtrichards joshtrichards added this to the Nextcloud App 3.31.0 milestone Nov 23, 2024
@alperozturk96 alperozturk96 force-pushed the fix/thumbnails-cache-resize-localid branch from 5602efc to dede489 Compare November 27, 2024 09:40
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice anything wrong. Thumbnails are generated without any issue.

Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing, I haven't been able to reproduce the problem with this fix in place.

Thank you for fixing this!

Fixes #13743

Signed-off-by: Josh <josh.t.richards@gmail.com>
@alperozturk96 alperozturk96 force-pushed the fix/thumbnails-cache-resize-localid branch from dede489 to 1d23c3a Compare November 28, 2024 10:15
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code298298
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total508508

@tobiasKaminsky tobiasKaminsky merged commit 581b258 into master Dec 5, 2024
17 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the fix/thumbnails-cache-resize-localid branch December 5, 2024 12:31
Copy link

backportbot bot commented Dec 5, 2024

The backport to stable-3.29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.29
git pull origin stable-3.29

# Create the new backport branch
git checkout -b backport/14081/stable-3.29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1d23c3a4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14081/stable-3.29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","field":"base","code":"invalid"}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants