Enhanced image preview #11897
Merged
Enhanced image preview #11897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobiasKaminsky
commented
Aug 11, 2023
•
- Tests written, or not not needed
cc0136e to
62db289
Compare
- exception handling in NominatimClient - set map boundaries - format strings according to locale - overlay drawables for photo pin correctly - refactored ImageDetailFragment - add copyright notices - add support for metadata from server - tint icons for dark mode Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
28f1b96 to
f57be44
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11897.apk |
AndyScherzinger
approved these changes
Aug 29, 2023
|
tested sucessfully 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.