Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10882 Slow Media Tab View #11281

Closed
wants to merge 0 commits into from
Closed

#10882 Slow Media Tab View #11281

wants to merge 0 commits into from

Conversation

digitaltechconsult
Copy link
Contributor

@digitaltechconsult digitaltechconsult commented Jan 20, 2023 •
edited by AlvaroBrey
Loading

Signed-off-by: eraser2021999 bcoticopol@gmail.com

Fixed unresponsiveness of the Media Tab (Photo Gallery) - more fluent scrolling.

  • implemented query search via created column and not modified to avoid cases when an older modified photo is display wrongly in the chronology;
  • changed some logic in media loading to improve the loading speed of the gallery;

Not fixed:

  • some issue with selecting a custom folder as gallery folder, I'm unsure if it worked correctly or not since the application crashed a lot;
  • some UI issues with the gallery display rectangles;
  • loading progress is not displayed correctly when scrolling faster, although the media is loading;

Manually tested with NextCloud Server (25.0.3) via simulator and hardware device (Google Pixel 6) with a media library of more than 10k items.

edits by repo admin
Issue links:
Partially solves #10425 (uses creation date instead of modification date)
Improves #10882

@digitaltechconsult
Copy link
Contributor Author

Hi @tobiasKaminsky, @AlvaroBrey

I believe I managed quite an improvement on the UI side, but I would suggest a thorough review and testing.

AlvaroBrey
AlvaroBrey reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@AlvaroBrey AlvaroBrey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, thanks @eraser2021999

However, in order to merge this, please accept the suggestion below, and please fix DCO check, instructions here: https://github.com/nextcloud/android/pull/11281/checks?check_run_id=10787404887

Please push further changes to this same PR rather than creating a new one, so we don't lose context.

app/src/main/java/com/owncloud/android/ui/asynctasks/GallerySearchTask.java Outdated Show resolved Hide resolved
@digitaltechconsult
Copy link
Contributor Author

It seems that my GitHub desktop broke something when tried to do the rebase --signoff. Pulling my hear out! :D

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7500-IT-master-23-58

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7500-IT-stable-00-06

@AlvaroBrey AlvaroBrey closed this Jan 24, 2023
@AlvaroBrey
Copy link
Member

Rebased and recreated the PR as #11288 to fix broken history here

AlvaroBrey pushed a commit that referenced this pull request Jan 26, 2023
@AlvaroBrey
#10882 Slow Media Tab View | Rebase of #11281 #11288
8af820d 
Signed-off-by: Bogdan Coticopol <bcoticopol@gmail.com>
- Workaround to improve gallery performance by eliminating the startDate from the query;
- Fixed a bug when the gallery would reset after playing a movie (searchAndDisplay);
@digitaltechconsult digitaltechconsult mentioned this pull request Jan 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey left review comments

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@starypatyk starypatyk Awaiting requested review from starypatyk

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@digitaltechconsult @nextcloud-android-bot @AlvaroBrey @szaimen