Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GalleryFragment: fix crash when scrolling slowly until the end of the list #11067

Merged
merged 1 commit into from
Nov 23, 2022
Merged

GalleryFragment: fix crash when scrolling slowly until the end of the list #11067

merged 1 commit into from
Nov 23, 2022

Conversation

AlvaroBrey
Copy link
Member

  • Tests written, or not not needed

@AlvaroBrey
GalleryFragment: fix crash when scrolling slowly until the end of the…
c1ce254 
… list

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey
Copy link
Member Author

/backport to stable-3.23

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8282
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4545
Dodgy code342342
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total508508

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11067.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6800-IT-stable-18-05

tobiasKaminsky
tobiasKaminsky approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never experienced it, but makes sense, as then follow up code cannot work.

@AlvaroBrey
Copy link
Member Author

AlvaroBrey commented Nov 23, 2022 •
edited
Loading

Never experienced it, but makes sense, as then follow up code cannot work.

I can reproduce it reliably with ~10 pictures and scrolling very slowly down. I found it while trying to debug #10882

@AlvaroBrey AlvaroBrey merged commit c938a92 into master Nov 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/gallery-crash branch November 23, 2022 21:10
@AlvaroBrey AlvaroBrey added this to the Nextcloud App 3.24.0 milestone Nov 23, 2022
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroBrey @nextcloud-android-bot @tobiasKaminsky