Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resized images: zoom behaviour #71

Closed
tobiasKaminsky opened this issue Jun 25, 2016 · 21 comments
Closed

Resized images: zoom behaviour #71

tobiasKaminsky opened this issue Jun 25, 2016 · 21 comments
Assignees

Comments

@tobiasKaminsky
Copy link
Member

Idea to download the full sized image:

  • Zooming a resized image with at least 2x (which can get blurry)
    • show snackbar "automatically download full image on zoom: yes"
    • Clicking "yes" after second time will offer option "always" to prevent showing the question.
  • time out the snackbar the second time by just waiting will show "never download full image" -> "yes".
  • after both show second snackbar without action "default behaviour can be changed in settings"
  • In setting: new entry "click on image downloads ..."
    • full image to storage
    • resized image to cache
@tobiasKaminsky tobiasKaminsky self-assigned this Jul 31, 2016
@AndyScherzinger AndyScherzinger mentioned this issue Aug 11, 2016
16 tasks
@tobiasKaminsky
Copy link
Member Author

After rethinking and partially programming it, I think these many snackbars are too much for the user.
So my new suggestion:
On zoom > 2x display a snackbar with "only resized image shown" and as action "change".
When clicking "change" it opens a (blocking) option selection box with
"What happens when zooming, ..."

  • show only resized image (default)
  • download full image
  • immediately download full image (old behaviour)

After setting an option, snackbar "Behaviour can be changed in settings" is shown.

Same is shown if the first snackbar times out (after ~5s).
The first snackbar is shown in total two times, both with second snackbar after timeout. After that no snackbar is shown ever again.

@jancborchardt @AndyScherzinger @mario

@AndyScherzinger
Copy link
Member

Sounds okay to me (no UX pro though), what about people who want to look at the pictures even on full resolution but still not download? I'd say we stop downloading and do just caching here and if people want to download them then have to explicitly select one/more images in the file list and select download.

What do you think about that?

cc @eppfel

@tobiasKaminsky
Copy link
Member Author

In your scenario the user would not have to do anything, as this is the default. The snackbar will vanish after the second time forever.
Manually downloading a specific file is always possible and the preview will be replaced seamless with the full version.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky I think not. If the user wants to preview the original images, then that is not one of the options you offer, at least not according to your list above?

@tobiasKaminsky
Copy link
Member Author

This is/can be an independent feature and should, for simplicity reason of this PR, be in a separate issue.

@mario
Copy link
Contributor

mario commented Mar 6, 2017

I think this should be the default behaviour though? Take a look at the full image, but don't download.

@AndyScherzinger
Copy link
Member

I think this should be the default behaviour though? Take a look at the full image, but don't download.

Me too, so it would then maybe be another topic and be something we change anyways (maybe for 1.5?). If you agree, can you open an issue for that?

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Mar 17, 2017

Then we cannot trigger the option dialog on zooming, but instead showing a snackbar the first two times a new user is previewing an image.
The snackbar displays "Full image is shown, but not saved" and a button "Change".

Clicking "change" shows these option dialog:
"Which image should be shown?"

  • Full size, not saved (this will be checked as default)
  • Full size, saved
  • Screen adapted preview
  • Preview, temporary full size on zoom

Clicking on any of these shows a snackbar with "Behaviour can be changed in preferences".

Improvements of the wordings is more than welcome :)

@tobiasKaminsky
Copy link
Member Author

Take a look at the full image, but don't download.

Best is to put the image into cache, otherwise you would have to download it over again if you swipe between two pictures.
Also I will set the cache to 200Mb, but we have a better approach #596 here.

@eppfel
Copy link
Member

eppfel commented Mar 25, 2017

I must admit I have a hard time following. Can we make a good decision on a default use case and then on other ones. And sometimes it is better not giving all possible options and stick with the relevant ones.

I feel the debate download full size vs storing full size is a question of transfer volume vs storage space and I generally tend to go for saving data transfer.
Cache is a good solution and when someone zooms he wants detail, so the default has to be downloading (not storing) full-res.

Can we retrieve a file from cache, when we download (and save to storage)?

There should be not more than one snackbar to determine default behaviour.

@tobiasKaminsky
Copy link
Member Author

@eppfel I think this is a good thing to discuss on meetup.

@jancborchardt
Copy link
Member

Why even display a snackbar? When you zoom in on an image so it would get blurry, of course the full resolution version should be downloaded automatically. :) Ideally without any disruptions or loading spinners or reloads.

No need for any snackbars, or settings, or extra things. Or am I missing something?

@tobiasKaminsky
Copy link
Member Author

@jancborchardt not again this one, please...
Many users do not want to have downloaded such a big file without explicit user interaction as they have a very limited data plan.

@jancborchardt
Copy link
Member

Alright, so then this snackbar would only appear on mobile network use for sure, not on wifi.

But even then - if they previously said "no" to downloading the full size, then do zoom into a picture at a later date … they would need to go to the settings to reactivate it?

This is best just done on a case-by-case basis rather than a setting. And when someone zooms in a considerable amount to a pictureto the point of blurryness, we can pretty much be sure that they would rather like to see the better-resolution version.
Otherwise they also might think that Nextcloud compressed their files, or only shows them in lower quality.

@jancborchardt
Copy link
Member

(And sorry @tobiasKaminsky :) maybe this is one best discussed in person at a hackweek.)

@tobiasKaminsky
Copy link
Member Author

Yes, please postpone it to Hackweek as we already talked about blurry images and therefore discussed to limit the zoom on resized images to 2x to still have a good enough picture... ;-)

@tobiasKaminsky
Copy link
Member Author

After leaving this thing some time alone, I think we want to achieve too many things on the same time and therefore the UI (and even talking about UI) is too complicated.

So this is (again) an idea to have far simpler:
Assumptions:

  • users do not want to download the whole image, instead just like streaming have only a resized version
  • if an user wants to have many images in original quality, he can synchronize the folder

This leads us to

  • always show a resized version
  • if an user zooms in (> 2x) a snackbar "download full image: yes" will be shown (on every time)
  • (to have the old behaviour: add setting "click on image downloads full image" (as checkbox))

To remind us of the benefit of the resized version:

  • you can share it to whatsapp, k9, facebook
  • it is ~100kb vs 2-5 Mb
  • resized images are stored in hard-coded 200Mb cache (see Cache size #596 for better cache sizing)

@jancborchardt
Copy link
Member

Ok, let's go with that for now. :)

Just one thing: Instead of the setting, I would say that specific syncing (via the menu) should also download the full quality.

@tobiasKaminsky
Copy link
Member Author

Syncing/Download menu entry will always download the full image.
The resized version will only be shown if you click directly on the image.

@jancborchardt
Copy link
Member

Great, then we agree. :)

@tobiasKaminsky
Copy link
Member Author

Closing this discussion as I integrated the result in #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants