-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resized images: zoom behaviour #71
Comments
After rethinking and partially programming it, I think these many snackbars are too much for the user.
After setting an option, snackbar "Behaviour can be changed in settings" is shown. Same is shown if the first snackbar times out (after ~5s). |
Sounds okay to me (no UX pro though), what about people who want to look at the pictures even on full resolution but still not download? I'd say we stop downloading and do just caching here and if people want to download them then have to explicitly select one/more images in the file list and select download. What do you think about that? cc @eppfel |
In your scenario the user would not have to do anything, as this is the default. The snackbar will vanish after the second time forever. |
@tobiasKaminsky I think not. If the user wants to preview the original images, then that is not one of the options you offer, at least not according to your list above? |
This is/can be an independent feature and should, for simplicity reason of this PR, be in a separate issue. |
I think this should be the default behaviour though? Take a look at the full image, but don't download. |
Me too, so it would then maybe be another topic and be something we change anyways (maybe for 1.5?). If you agree, can you open an issue for that? |
Then we cannot trigger the option dialog on zooming, but instead showing a snackbar the first two times a new user is previewing an image. Clicking "change" shows these option dialog:
Clicking on any of these shows a snackbar with "Behaviour can be changed in preferences". Improvements of the wordings is more than welcome :) |
Best is to put the image into cache, otherwise you would have to download it over again if you swipe between two pictures. |
I must admit I have a hard time following. Can we make a good decision on a default use case and then on other ones. And sometimes it is better not giving all possible options and stick with the relevant ones. I feel the debate download full size vs storing full size is a question of transfer volume vs storage space and I generally tend to go for saving data transfer. Can we retrieve a file from cache, when we download (and save to storage)? There should be not more than one snackbar to determine default behaviour. |
@eppfel I think this is a good thing to discuss on meetup. |
Why even display a snackbar? When you zoom in on an image so it would get blurry, of course the full resolution version should be downloaded automatically. :) Ideally without any disruptions or loading spinners or reloads. No need for any snackbars, or settings, or extra things. Or am I missing something? |
@jancborchardt not again this one, please... |
Alright, so then this snackbar would only appear on mobile network use for sure, not on wifi. But even then - if they previously said "no" to downloading the full size, then do zoom into a picture at a later date … they would need to go to the settings to reactivate it? This is best just done on a case-by-case basis rather than a setting. And when someone zooms in a considerable amount to a pictureto the point of blurryness, we can pretty much be sure that they would rather like to see the better-resolution version. |
(And sorry @tobiasKaminsky :) maybe this is one best discussed in person at a hackweek.) |
Yes, please postpone it to Hackweek as we already talked about blurry images and therefore discussed to limit the zoom on resized images to 2x to still have a good enough picture... ;-) |
After leaving this thing some time alone, I think we want to achieve too many things on the same time and therefore the UI (and even talking about UI) is too complicated. So this is (again) an idea to have far simpler:
This leads us to
To remind us of the benefit of the resized version:
|
Ok, let's go with that for now. :) Just one thing: Instead of the setting, I would say that specific syncing (via the menu) should also download the full quality. |
Syncing/Download menu entry will always download the full image. |
Great, then we agree. :) |
Closing this discussion as I integrated the result in #69 |
Idea to download the full sized image:
The text was updated successfully, but these errors were encountered: