Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Android 4.0.x support #2923

Closed
AndyScherzinger opened this issue Aug 24, 2018 · 23 comments · Fixed by #4777
Closed

Drop Android 4.0.x support #2923

AndyScherzinger opened this issue Aug 24, 2018 · 23 comments · Fixed by #4777
Labels
enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale.

Comments

@AndyScherzinger
Copy link
Member

I'd like to slowly but steadily remove support for (very) old Android versions and would like to start with dropping 4.0.x making 4.1 the minimum version (baby steps). Looking at the numbers the app lost 16% of the total 4.0.x active installations dropping down to 161 devices, so I think we are safe to remove the support after 3.3.x which would then be the last feature release which is the first one to support Nc14 features.

Here is the actual 4.0.x active installations graph for the last month:
android_4_0_x

What do you think @mario @ardevd @tobiasKaminsky

@AndyScherzinger AndyScherzinger added the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Aug 24, 2018
@ardevd
Copy link
Collaborator

ardevd commented Aug 24, 2018

I absolutely support this! I would probably make 5.0 the minimum version but as you say - baby steps!

@mario
Copy link
Contributor

mario commented Aug 24, 2018 via email

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Aug 24, 2018

Well, dropping 4.x and making 5.x the minimum version would drop support for 3,4% of the active users where 4.4 has the same amount of users as 5.0 (with both having more than 5000 users each!). That is why I thought of baby steps since I don't see a good reason to drop support for >5000 people.

Easier maintenance isn't an argument from my point of view if nobody finds the time to take care of improving the auto upload which is where > Android 5.0 might be helpful. So in my opinion just dropping 4.x and leaving the actual features as-is, is just dropping support for a lot of people for no reason.

@tobiasKaminsky
Copy link
Member

Currently we cannot drop 4.x support as this is a requirement for some customers.
I can check if 4.4.x would be enough.
Once this change, we can of course drop the support.

@AndyScherzinger
Copy link
Member Author

Which is why I opened the issue for dropping_4.0.x_only

@rullzer
Copy link
Member

rullzer commented Sep 5, 2018

4.0 is fine and totally defendable IMO. And indeed baby steps.

@tobiasKaminsky
Copy link
Member

Last time I asked @oparoz, he said 4.x…

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Sep 5, 2018

@oparoz can you clarify on this, especially talking about 4.0.x (since it has been released Oct. 2011, overall market share <0,3%, for Nc it's <0,1% meaning 150 devices, declining by about 20% each month).

@AndyScherzinger
Copy link
Member Author

@oparoz @tobiasKaminsky any news and feedback on dropping Android 4.0.x making Android 4.1 the minimum requirement?

@tobiasKaminsky
Copy link
Member

From my side, last info is that 4.x is required by a customer and thus we have to support it.
@oparoz, please clarify

@rullzer
Copy link
Member

rullzer commented Oct 9, 2018

Also note that google will most likely drop support for chrome in anything below 4.4 soon.

@tobiasKaminsky
Copy link
Member

@oparoz what is our least supported version?
4.0.x is really a bit old…
So I agree that we should remove this, if possible.

@rullzer
Copy link
Member

rullzer commented Dec 17, 2018

Google is even dropping support for it. So play services will no longer work.

@tobiasKaminsky
Copy link
Member

@rullzer do you have a reference for this?

@rullzer
Copy link
Member

rullzer commented Dec 17, 2018

https://android-developers.googleblog.com/2018/12/google-play-services-discontinuing.html

@AndyScherzinger
Copy link
Member Author

Again, and again and again: @tobiasKaminsky @oparoz can we get an answer on this? Keeping this blocked by not deciding on it since over a year is just sad
2019-09-17 08_41_04-Statistics - Nextcloud - Google Play Console

@tobiasKaminsky
Copy link
Member

What about this idea?
If oldest version is <0.5% then we drop it?
https://developer.android.com/about/dashboards/index.html

So we would right now drop 4.0.x and have min 16?

@rullzer
Copy link
Member

rullzer commented Oct 18, 2019

That chart is not really up to date. But I'm totally fine with starting to drop ancient versions.

@tobiasKaminsky
Copy link
Member

Right, they updated it in May and now recommend to use our own statistics available in dev console.

so this are our oldest android version with active installations:
image

Which threshold shall we use?
I would like to have decision that we can use to check just before when releasing a RC1.

We have right now 400k active installations. so 400 users are 0.1%.
Shall we take this as a threshold?
That means we can right now deprecate 4.0.x, but maybe on 3.9 RC1 even 4.1.

(we cannot deprecate 4.3 as it is only possible to specify a min version, nothing inbetween).

If we agree on this, we should make this info available on release.
Users with older devices still can use the old versions…

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 18, 2019

So which threshold are you proposing @tobiasKaminsky? Your last 2 comments propose different ones: 0.1 and 0.5.

Personally I'd say 0.1 is too little but for 3.10 I'd say we can make v16 the min version.
Since 3.9 RC1 is in 10 days I would not start dropping support yet since we want to do some housekeeping on the way.

What do you think?

After that I'd even go as far as to make Android 4.4 the min version for 3.11.

@rullzer
Copy link
Member

rullzer commented Oct 19, 2019

0.1% seems very low to me ;) We don't even support browsers with that small percentage.

IMO: 0.5% && EOL seems fair.
But I'm also fie to start with 0.1% if you feel more confortable with that. As long as we start with something.

@AndyScherzinger
Copy link
Member Author

I am with @rullzer on the threshold, <=0,5% and EOL

@tobiasKaminsky
Copy link
Member

Well then let us use 0.5% for the version after this (3.10).

I update the overview issue then.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Oct 31, 2019
@AndyScherzinger AndyScherzinger changed the title Drop Android 4.0.x support for app release 3.4.0 Drop Android 4.0.x support for app release 3.10.0 Nov 28, 2019
@AndyScherzinger AndyScherzinger changed the title Drop Android 4.0.x support for app release 3.10.0 Drop Android 4.0.x support Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants