Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise CHUNK_SIZEs #622

Closed
wants to merge 1 commit into from
Closed

Raise CHUNK_SIZEs #622

wants to merge 1 commit into from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 13, 2021

fix nextcloud/android#8398
Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings12
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

Lint increased!

@tobiasKaminsky
Copy link
Member

We will not change the default without any deeper knowledge if this is a good idea.
For other apps that use the library we could introduce a more flexible way, so that the apps can pass their desired chunk size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise CHUNK_SIZEs
3 participants