Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrieve recommendations #1605

Merged
merged 7 commits into from
Jan 21, 2025
Merged

retrieve recommendations #1605

merged 7 commits into from
Jan 21, 2025
+167 −8

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 12, 2024 •
edited
Loading

@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 12, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

alperozturk96
alperozturk96 previously approved these changes Jan 8, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

alperozturk96
alperozturk96 requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@alperozturk96 alperozturk96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky Could you add capability for the recommendation so that client dont do unnecessary network calls?

com.owncloud.android.lib.resources.status.OCCapability

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3793-IT-master-11-02/debug/

@tobiasKaminsky
retrieve recommendations
b518f6a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Drone: add recommendations
f8046f5 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
spotless
75e5ec0 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
update drone
3f6116c 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
add capability
980a340 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
check only with NC31+
ab32c08 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
update after rebase
142588c 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3807-IT-master-11-00/debug/

@tobiasKaminsky tobiasKaminsky merged commit e399f10 into master Jan 21, 2025
17 of 18 checks passed
@tobiasKaminsky tobiasKaminsky deleted the recommendations branch January 21, 2025 11:34
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.20.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
NC Android lib 2.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasKaminsky @nextcloud-android-bot @alperozturk96 @AndyScherzinger