S3 multipart upload #1173
Merged
S3 multipart upload #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
============================================
+ Coverage 51.90% 52.09% +0.19%
+ Complexity 968 966 -2
============================================
Files 187 187
Lines 6922 6906 -16
Branches 914 911 -3
============================================
+ Hits 3593 3598 +5
+ Misses 2819 2798 -21
Partials 510 510
|
850b309 to
284c03f
Compare
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- refactor to use new Chunk class - remove incompatible test cases Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- test on wifi and mobile Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- fix calculation of chunk size - increase CHUNK_SIZE_MOBILE to 10M - server enforced minimum of > 5M - increase CHUNK_SIZE_WIFI to 40M - reformat file Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- ported java class to kotlin - added test cases for calculation of chunks - no chunks available on server - some chunks available - switch chunkSize during upload Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- increase size of BIG_FILE_ITERATION - previously about 14 MB, now about 28 MB Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
89c9344 to
5a63262
Compare
- chunks in S3 may loose padding - move Chunk.java to data class Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for chunked uploads to s3 via s3 multipart upload, as requested in nextcloud/files-clients#28. The server-side implementation has been merged with nextcloud/server#27034, and the corresponding documentation can be found here: nextcloud/documentation#10740.
TODO
closes nextcloud/android#11745