Avatar Generation does not work of single letter users #1628

szaimen · 2022-12-29T12:22:17Z

Already tried a lot of things but nothing did make it work:

add freetype-dev and fontconfig-dev for compiliing imagick #1624
add other file types as well #1626
move imagick back to the dockerfile #1627
7a6f350
d06b3a7
810094d
todo: check if it works with php8.1

The text was updated successfully, but these errors were encountered:

szaimen · 2023-01-10T11:57:20Z

Maybe it has to do with imagemagicks policy.xml but I tried to modify that and it still didnt work so out of ideas again...

ManOki · 2023-01-17T18:55:17Z

does not work even with long user names

szaimen · 2023-01-17T19:06:53Z

Interesting! So yeah, I tried my best but didn't find a solution. Help on this is appreciated! My last thought was that it might be the policy.xml from imaginary but even adjusting that didn't made it work...

Zoey2936 · 2023-01-17T19:20:22Z

Does this error only exist under some conditions? Since on my AIO Instance it is working... (v4.2.0)

szaimen · 2023-01-17T19:23:31Z

Does this error only exist under some conditions? Since on my AIO Instance it is working... (v4.2.0)

do you have imagick installed and enabled?

Zoey2936 · 2023-01-17T19:29:19Z

Does this error only exist under some conditions? Since on my AIO Instance it is working... (v4.2.0)

do you have imagick installed and enabled?

I would say yes and in my config.php is set:

  'enabledPreviewProviders' => 
  array (
    1 => 'OC\\Preview\\Image',
    2 => 'OC\\Preview\\MarkDown',
    3 => 'OC\\Preview\\MP3',
    4 => 'OC\\Preview\\TXT',
    5 => 'OC\\Preview\\OpenDocument',
    6 => 'OC\\Preview\\Movie',
    0 => 'OC\\Preview\\Imaginary',
  ),
  'enable_previews' => true,
  'preview_imaginary_url' => 'http://nextcloud-aio-imaginary:9000',

szaimen · 2023-01-17T19:31:20Z

do you have imagick installed and enabled?

You can check it here: https://yourdomain.com/settings/admin/overview. If it is not enabled it should show a warning.

Zoey2936 · 2023-01-17T19:33:28Z

szaimen · 2023-01-17T19:34:33Z

hm, okay then no idea why it works for you. Maybe some difference between arm64 and amd64? But yeah, really no clue.

szaimen · 2023-01-17T19:35:07Z

btw, one workaround that I've found is disabling imagemagick but this will show a warning in the admin overview so is really only a workaround.

EgonHeuson · 2023-01-24T22:47:10Z

Hello! I did some quick behavior tests and here are the results (on my amd64 config).
When I add an avatar to a user, its avatar is generated correctly, and it can see the avatars of the users that added avatars to themselves before him somehow.
I noticed I had this problem too this evening, then to test I added a Dog avatar to a test account just to see if it was only coming from the letters avatar or from all. Strangely it seems to propagate as it can be seen below.
Here is what I see if I connect to my account:

Then I tested the same with the admin account to check, and I get this when I'm connected with this account:

So it seems to see all the avatars. But when I come back to my account, I still cannot see the one of my admin account:

Same for a 4th account I tested, but this time it can see its own avatar, but not the one of my account like the Admin account.
I don't know if this might help you or not? I can do some more testing if you like :-)

EgonHeuson · 2023-01-25T09:20:06Z

Samll update on this :-) This morning, I just reconnected to my nextcloud account and now I can see the avatar of my admin account :-) However, it is not the good one showing 😅. Here is what I get from my user account:

And here is what I get from my admin account (when I go to "users"):

The second image is the actual one. The first one is one image I first uploaded yesterday evening to see it it worked, and then I uploaded the second one. Strange no?
Also, I asked a friend of mine who has an account to add a picture. And 1) it could yesterday see all of the ones that where already uploaded to my user accounts and my admin account, and 2) I now can see his avatar while I could not see it yesterday evening just after it uploaded it.
I have to precise that I execute this command every night at 3am via a Cron job: docker exec --user www-data nextcloud-aio-nextcloud /var/www/html/occ files:scan --all
It is to update the files that I may have manually added in my Nextcloud folder on my NAS. But maybe it refreshes something else?
One last thought, I feel like when somebody adds up a new avatar, the people who does it sees the ones of the people that already uploaded their avatar before him, but not those who did it after. And more that it might get reseted on specific action/command/event, or maybe it just take some time to propagate to the other users?
You didn't propose a mastercontainer update the last night, right?

szaimen · 2023-01-25T12:30:22Z

Thanks for your posts @EgonHeuson! However the more I think about your findings, the more I think that this is a different bug than the one that this issue is about. The bug which this issue is about is only about the default avatars not getting generated correctly.

EgonHeuson · 2023-01-25T13:03:25Z

Argh damned! 😅 I also have the issue with default avatars generation but hard to distinguish if it is link to the other issue in my case or not... 😥

VitaleyUsa · 2023-01-28T16:43:46Z

Sorry for the long reply.
Just did a quick test with profile avatars when i'm not logged in: i can see generated avatar picture (but with one letter instead of two)
for example: when i'm already logged in, only background shown with no letters
when i'm logged out and just checking profile link of the same user: i can see letter on profile pic:

or maybe i not properly cleaned avatar cache?

szaimen · 2023-01-28T16:45:07Z

or maybe i not properly cleaned avatar cache?

Can you clear the browser cache ans check if it still works?

VitaleyUsa · 2023-01-28T17:29:23Z

or maybe i not properly cleaned avatar cache?

Can you clear the browser cache ans check if it still works?

it works, i'm testing in incognito to remove cache factor :)

szaimen · 2023-01-28T17:32:52Z

All right. Just tried on my test instance and avatar generation of single name users does not work even in incognito tab. Are you on arm64?

VitaleyUsa · 2023-01-28T17:37:11Z

All right. Just tried on my test instance and avatar generation of single name users does not work even in incognito tab. Are you on arm64?

Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 40 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 2 On-line CPU(s) list: 0,1 Vendor ID: AuthenticAMD Model name: Common KVM processor CPU family: 15 Model: 6 Thread(s) per core: 1 Core(s) per socket: 2 Socket(s): 1 Stepping: 1 BogoMIPS: 4599.99 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx lm rep_good nopl cpuid extd_apicid tsc_known_freq pni cx16 x2apic hypervisor cmp_legacy 3dnowprefetch vmmcall Virtualization features: Hypervisor vendor: KVM Virtualization type: full Caches (sum of all): L1d: 128 KiB (2 instances) L1i: 128 KiB (2 instances) L2: 1 MiB (2 instances) L3: 32 MiB (2 instances) NUMA: NUMA node(s): 1 NUMA node0 CPU(s): 0,1 Vulnerabilities: Itlb multihit: Not affected L1tf: Not affected Mds: Not affected Meltdown: Not affected Mmio stale data: Not affected Retbleed: Not affected Spec store bypass: Not affected Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling Srbds: Not affected Tsx async abort: Not affected

i'm noticed that in incognito mode i have dif. language:

when i'm logged in:

szaimen · 2023-01-28T17:39:36Z

So it seems to work for you correctly on x64. Now I am even more clueless...

VitaleyUsa · 2023-01-28T17:40:37Z

So it seems to work for you correctly on x64. Now I am even more clueless...

no! sorry, deleted my upd: it's what i have when i'm using ur hack from another thread

VitaleyUsa · 2023-01-28T17:43:23Z

Sorry for misunderstand.
I did last screen (with ur fix from another thread) only to show u that i have dif. language.
But when i have no fix enabled, it shows letters only when i'm not logged in.

szaimen · 2023-01-28T17:50:29Z

But when i have no fix enabled, it shows letters only when i'm not logged in.

Which fix? you mean disabling imagemagick?

VitaleyUsa · 2023-01-28T17:55:23Z

But when i have no fix enabled, it shows letters only when i'm not logged in.

Which fix? you mean disabling imagemagick?

nextcloud/server#34755 (comment)

szaimen · 2023-01-28T17:57:24Z

This comment is not made by me.

VitaleyUsa · 2023-01-28T18:00:33Z

Ooooooh, all this time i thought it was yours :(
sorry!

szaimen · 2023-01-28T18:06:49Z

All good!

VitaleyUsa · 2023-01-29T09:35:32Z

Just did another test with no fix:

That's what i have when i'm logged in:
That's what i have when i'm not logged in (no cache):

Also, i decide to check what happening when i'm cleaning avatar folder:

When i'm logged in:
When i'm not logged in:

Seems like, when i'm not logged in profile pictures are generating in some other place (not in data/appdata_xxxxx/avatar):

So.. when you not logged in, nextcloud uses different way to show profile picture, it's not generated then. I checked source code of the page (changed name to "Test"):

the result:

probably, no point to search in this way, cuz it has dif. way of profile pic. generation (also no correlation with language, i tried Ru lang, it still works when i'm not logged in)

VitaleyUsa · 2023-01-29T11:20:03Z

@szaimen

i'm not a real programmer and my english is far from perfect, so ...

https://github.com/nextcloud/server/blob/v25.0.0/lib/private/Avatar/Avatar.php#L142

is it right that this line looks like this: catch (\Exception $e)
because if i changing it to: catch (Exception $e)
(removing backslash symbol before Exception)
it's starts to work as expected.
as i can see it's something with using global namespaces (and catching all exceptions instead of local?) but i can't understand why it ruins avatar generation anyway.
is it because some exception appears, and function returns null because of it?

so, in summary:

remove avatar cache from nc folder and from browser
remove backslash symbol in Avatar.php in 142 line "catch (Exception $e)" (use local exception instead of global) or remove try cache block
generate avatars by php occ files:scan-app-data avatar
it is generating avatars now

Did some tests and find out that profile pics are generating in every place (on main dashboard, in list of users) except when you come to user profile, so prob. that's the main problem, exception just won't allow script to generate everything else.
I mean... when we have exception enabled - it starts to generate profile pic for user profile, something happening (exception appears) and function return null and not trying to generate profile pics that are shown on main board and in the list of users.

i dunno how to show exception by changing Avatar.php, tried this:
echo 'Message: ' .$e->getMessage();
but it's not working
so can't say anything more about this :]

ps what function are responsible for profile pic generation when u go direct to user profile?

szaimen · 2023-01-30T16:11:53Z

Sorry, I have also already played with this a lot and no changes in catching the exception make any difference on my test instance. So it should work since no error is thrown but it doesnt generate the avatar. As you, I am out of ideas but thanks for your attempt!

VitaleyUsa · 2023-01-30T17:43:16Z

Sorry, I have also already played with this a lot and no changes in catching the exception make any difference on my test instance. So it should work since no error is thrown but it doesnt generate the avatar. As you, I am out of ideas but thanks for your attempt!

I might be wrong, but it seems like the problem here = svg format.
Try to add this code:

$avatar->setFormat('SVG');

before this line: https://github.com/nextcloud/server/blob/v25.0.0/lib/private/Avatar/Avatar.php#L137

In result it should be like this:

> protected function generateAvatarFromSvg(int $size, bool $darkTheme): ?string {
>                 if (!extension_loaded('imagick')) {
>                         return null;
>                 }
>                 try {
>                         $font = __DIR__ . '/../../../core/fonts/NotoSans-Regular.ttf';
>                         $svg = $this->getAvatarVector($size, $darkTheme);
>                         $avatar = new Imagick();
>                         $avatar->setFont($font);
>                         $avatar->setFormat('SVG');
>                         $avatar->readImageBlob($svg);
>                         $avatar->setImageFormat('png');
>                         $image = new \OCP\Image();
>                         $image->loadFromData((string)$avatar);
>                         return $image->data();
>                 } catch (\Exception $e) {
>                         return null;
>                 }
>         }
>

Now everything is fine. Avatars are generating in every place as it should be.

Am i wrong?

ps strange thing here: svg template already have this:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
but it's not working, maybe something is changing svg template and first line is corrupted?

szaimen · 2023-02-08T12:04:30Z

Cross-linking nextcloud/server#36607 here. However I hope that we'll find a solution to this sooner.

spss20 · 2023-03-17T11:40:30Z

I've been following this issue for a long time. Why is there no solution yet for a simple thing? It's been months.

szaimen · 2023-03-17T11:42:35Z

Why is there no solution yet for a simple thing? It's been months.

Because we didnt found a solution yet. See our investigations and attempts above.

If the solution would be easy, we would have fixed the problem a long time ago.

If you have further ideas on a technical solution, feel free to post them here.

spss20 · 2023-03-17T14:29:12Z

@szaimen Thanks for updating. However i would like to bring the fact that there is no such issue in the docker standalone version of nextcloud. The problem exists only in all-in-one installation of nextcloud. Just curious.

szaimen · 2023-03-17T15:34:49Z

However i would like to bring the fact that there is no such issue in the docker standalone version of nextcloud.

did you use the fpm-alpine image or the apache version?

Jip-Hop · 2023-03-17T17:01:40Z

I have the same issue on a linuxserver.io nextcloud image so the issue isn't exclusive to aio. Both are based on alpine though.

szaimen · 2023-03-17T17:05:47Z

I have the same issue on a linuxserver.io nextcloud image so the issue isn't exclusive to aio. Both are based on alpine though.

Yes, this is my observation as well.

szaimen · 2023-03-29T10:52:12Z

nextcloud/server#34755 (comment)

szaimen · 2023-03-30T12:29:01Z

nextcloud/server#37378

after #1628 was fixed Signed-off-by: Simon L <szaimen@e.mail.de>

szaimen added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Dec 29, 2022

szaimen changed the title ~~Avatar Generation does not work. Maybe need imagemagick6?~~ Avatar Generation does not work of single letter users Dec 29, 2022

szaimen added the help wanted Extra attention is needed label Dec 29, 2022

szaimen mentioned this issue Jan 9, 2023

Avatar is coming black by default #1703

Closed

szaimen added 1. to develop Accepted and waiting to be taken care of high High priority and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 16, 2023

szaimen mentioned this issue Jan 24, 2023

[Bug]: Single letter avatars in Nextcloud 24 have become all white icons in Nextcloud 25 on Alpine Linux with imagemagick installed nextcloud/server#34755

Closed

9 tasks

szaimen mentioned this issue Feb 15, 2023

[Bug]: Avatars don't show initials nor pictures in nextcloud 25 nextcloud/server#36722

Closed

9 tasks

szaimen closed this as completed Mar 30, 2023

szaimen added a commit that referenced this issue Apr 1, 2023

remove temporarily added dependencies after avatar problem was fixed

287a5a0

after #1628 was fixed Signed-off-by: Simon L <szaimen@e.mail.de>

szaimen mentioned this issue Apr 1, 2023

remove temporarily added dependencies after avatar problem was fixed #2255

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023

Avatar Generation does not work of single letter users #1628

Avatar Generation does not work of single letter users #1628

Comments

szaimen commented Dec 29, 2022 • edited Loading

szaimen commented Jan 10, 2023

ManOki commented Jan 17, 2023

szaimen commented Jan 17, 2023

Zoey2936 commented Jan 17, 2023

szaimen commented Jan 17, 2023

Zoey2936 commented Jan 17, 2023

szaimen commented Jan 17, 2023

Zoey2936 commented Jan 17, 2023

szaimen commented Jan 17, 2023

szaimen commented Jan 17, 2023

EgonHeuson commented Jan 24, 2023

EgonHeuson commented Jan 25, 2023

szaimen commented Jan 25, 2023

EgonHeuson commented Jan 25, 2023

VitaleyUsa commented Jan 28, 2023

szaimen commented Jan 28, 2023

VitaleyUsa commented Jan 28, 2023

szaimen commented Jan 28, 2023

VitaleyUsa commented Jan 28, 2023 • edited Loading

szaimen commented Jan 28, 2023

VitaleyUsa commented Jan 28, 2023

VitaleyUsa commented Jan 28, 2023

szaimen commented Jan 28, 2023

VitaleyUsa commented Jan 28, 2023

szaimen commented Jan 28, 2023

VitaleyUsa commented Jan 28, 2023

szaimen commented Jan 28, 2023

VitaleyUsa commented Jan 29, 2023 • edited Loading

VitaleyUsa commented Jan 29, 2023 • edited Loading

szaimen commented Jan 30, 2023 • edited Loading

VitaleyUsa commented Jan 30, 2023 • edited Loading

szaimen commented Feb 8, 2023 • edited Loading

spss20 commented Mar 17, 2023

szaimen commented Mar 17, 2023 • edited Loading

spss20 commented Mar 17, 2023

szaimen commented Mar 17, 2023

Jip-Hop commented Mar 17, 2023

szaimen commented Mar 17, 2023

szaimen commented Mar 29, 2023

szaimen commented Mar 30, 2023

szaimen commented Dec 29, 2022 •

edited

Loading

VitaleyUsa commented Jan 28, 2023 •

edited

Loading

VitaleyUsa commented Jan 29, 2023 •

edited

Loading

VitaleyUsa commented Jan 29, 2023 •

edited

Loading

szaimen commented Jan 30, 2023 •

edited

Loading

VitaleyUsa commented Jan 30, 2023 •

edited

Loading

szaimen commented Feb 8, 2023 •

edited

Loading

szaimen commented Mar 17, 2023 •

edited

Loading