Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @nextcloud/vue to 7 beta #923

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Bump @nextcloud/vue to 7 beta #923

merged 7 commits into from
Sep 13, 2022

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen
Bump @nextcloud/vue to 7 beta
b690ddc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Upgrade component names
da5b1ff 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
b983e74 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Sep 13, 2022
@nickvergessen nickvergessen marked this pull request as ready for review September 13, 2022 09:09
@artonge
Correctly export randHash
3b836dd 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Update test snapshots
5c6bcce 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Copy link
Collaborator

artonge commented Sep 13, 2022

Pushed a fix for snapshots and wrongly exported util function.

@nickvergessen
Copy link
Member Author

1 failing

  1. Check that user's settings survive a reload
    Activity summary survive a reload:
    AssertionError: Timed out retrying after 4000ms: Expected to find element: input, but never found it. Queried from element: <span.checkbox-radio-switch.checkbox-radio-switch-checkbox>
    at Context.eval (http://localhost:8081/__cypress/tests?p=cypress/integration/settings.spec.js:187:129)

@nickvergessen
Fix empty content of dashboard
57770ae 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Sep 13, 2022
Closed
@nickvergessen
Copy link
Member Author

/backport 57770ae to stable24

@artonge
Copy link
Collaborator

artonge commented Sep 13, 2022

Pushed a fix for cypress tests

@artonge
Copy link
Collaborator

artonge commented Sep 13, 2022 •
edited
Loading

Looks like it does not work fully, don't have time today, will look into it tomorrow afternoon

@artonge
Rewrite cypress test
41ac69c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feature/noid/update-vue-to-7 branch from b6a9181 to 41ac69c Compare September 13, 2022 14:36
@nickvergessen
Copy link
Member Author

🎉

@nickvergessen nickvergessen merged commit f97620e into master Sep 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/update-vue-to-7 branch September 13, 2022 15:04
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 13, 2022
Merged
1 task
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @artonge