Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly import the ActivityTab dynamically #1112

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 9, 2023

dynamic imports return the imported component as { default }. This fixes loading the activity sidebar in files.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

/backport to stable26

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

FYI @AndyScherzinger Might be good to still have the backport of this in rc2 as without the files activity sidebar is not working.

Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, makes sense. I wonder why my tests didn't catch this :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants