Use accesslist from the new share manager #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
commented
Jan 10, 2017
lib/FilesHooks.php
Outdated
| $accessList = $this->shareManager->getAccessList($node, true, true); | ||
| $helper = new ShareHelper($this->rootFolder); // FIXME | ||
|
|
||
| $nodes = $helper->getPathsForAccessList($node, $accessList['users']); |
There was a problem hiding this comment.
This sets up all the users and is therefor very slow :/
Also I wonder about a potential memory issue with nodes being loaded for all users
There was a problem hiding this comment.
I don't think memory issues are the main concern here. Yes it is slow. But as discussed the old endpoint just returned false info in some cases.
Would it maybe make sense to just use the filename and link to the file by using not a path but the nodeid?
Signed-off-by: Joas Schilling <coding@schilljs.com>
66783c2 to
00d07c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#2834
Fix #61