Use multipartupload for uploading chunks to s3 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
|
Edge-case since on mobile you probably don't upload files that large, but would it make sense to have some extra assertion to not let the chunk count exceed 10.000? |
Sure, i'm just not sure what we can do as a solution to this edge case. A simple print with an error might be enough for just the lib, but for the Files app we need to do more than that. I'll see what I can do. |
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
…nto 2471-use-multipartupload-for-uploading-chunks-to-s3-2
marinofaggiana
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the names of the chunks to start from 1 and be only numerical
Related to nextcloud/ios#2541
Docs: nextcloud/documentation#10740