Patch ZipStreamer to fix directory downloads #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2018
|
How to test this? The zip files work before and after this patch on my Windows 10 machine. With macOS they don't work (neither before nor after this patch). |
|
Ask people of nextcloud/server#2352 for the setup configurations. |
nickvergessen
commented
Jan 9, 2018
| @@ -525,7 +525,7 @@ private function buildCentralDirectoryHeader($filePath, $timestamp, $gpFlags, | |||
| private function buildEndOfCentralDirectoryRecord($cdRecLength) { | |||
| if ($this->zip64) { | |||
| $diskNumber = -1; | |||
| $cdRecCount = -1; | |||
| $cdRecCount = min(sizeof($this->cdRec), 0xffff);; | |||
There was a problem hiding this comment.
Could you fix the extra space and the extra ; and then this is good for me.
rullzer
approved these changes
Jan 10, 2018
1 task
Signed-off-by: Joas Schilling <coding@schilljs.com>
7db35ff to
4ec6dd6
Compare
MorrisJobke
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches ZIpStreamer with McNetic/PHPZipStreamer#39 to fix nextcloud/server#2352