-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: import remark-gfm library in NcRichText as module, not async #6506
Conversation
This reverts commit 49ce673. Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
bf3ade2
to
2f3ece2
Compare
Would it not be possible to just keep showing the skeletons until loading is finished? |
We could show the text until the (I missed that it shows only a spinner). But even with the text, we cannot predict the result size, having all the headings, lists, code blocks and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I wasn't fun of it initially, as mentioned in the original PR
If you're asking whether it's possible to do on app side, we then need to trigger async import while it's loading (e.g. place NcRichText with markdown somewhere hidden to trigger it on initial load), and show skeleton until internal component state is updated? Not sure that's a good idea.. |
We can separate it into two components:
|
It was more like:
Do we use the non-markdown versions somewhere? Because if not then it makes not much sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyways makes sense here
Found some usages in Talk, Activity, integration apps, could be somewhere else. So some may benefit from it, especially if discussed |
/backport to next |
☑️ Resolves
After some testing, I'm not happy with the results. async load of ~40kB comes with side effect of resizing of components, which doesn't look good in long lists (Talk)
🖼️ Screenshots
🏚️ Before
2025-02-11_10h36_17.mp4
🏡 After
2025-02-11_10h44_40.mp4
🏁 Checklist
next
requested with a Vue 3 upgrade