Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract un-escaping of text/code nodes with XML-like content #6499

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: extract un-escaping of text/code nodes with XML-like content #6499

merged 2 commits into from
Feb 7, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 6, 2025

☑️ Resolves

  • Fix broken parsing caused by early/late escaping of special characters
    • should be done after remarkParse, so it's not stripped
    • should be done before remarkGfm, so it's correctly parsed

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
test: extend cases of parsing XML-like text
75b96ac 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: extract un-escaping of text/code nodes
c290a62 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Feb 6, 2025
@Antreesy Antreesy added this to the 8.23.0 milestone Feb 6, 2025
@Antreesy Antreesy requested review from susnux and ShGKme February 6, 2025 21:04
@Antreesy Antreesy self-assigned this Feb 6, 2025
@Antreesy
Copy link
Contributor Author

Antreesy commented Feb 7, 2025

/backport to next

@Antreesy Antreesy merged commit d5043f6 into master Feb 7, 2025
23 checks passed
@Antreesy Antreesy deleted the fix/noid/rich-escape branch February 7, 2025 17:14
@backportbot backportbot bot mentioned this pull request Feb 7, 2025
Merged
This was referenced Feb 7, 2025
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @ShGKme